From: Guenter Roeck <linux@roeck-us.net>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Scott Feldman <sfeldma@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Jerome Oufella <jerome.oufella@savoirfairelinux.com>,
linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,
Chris Healy <cphealy@gmail.com>
Subject: Re: [RFC 6/9] net: dsa: mv88e6352: allow egress of unknown multicast
Date: Tue, 02 Jun 2015 07:20:53 -0700 [thread overview]
Message-ID: <556DBBC5.5050009@roeck-us.net> (raw)
In-Reply-To: <1433208470-25338-7-git-send-email-vivien.didelot@savoirfairelinux.com>
On 06/01/2015 06:27 PM, Vivien Didelot wrote:
> This patch disables egress of unknown unicast destination addresses.
>
Hi Vivien,
seems to me this patch is unrelated to the rest of the series.
Not sure if we really want this. If an address is in the arp cache
but has timed out from the bridge database, any unicast to that address
will no longer be sent. If the bridge database has been flushed for some
reason, such as a spanning tree reconfiguration, we'll have a hard time
to send anything.
What is the problem you are trying to solve with this patch ?
Thanks,
Guenter
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> ---
> drivers/net/dsa/mv88e6xxx.c | 3 ++-
> drivers/net/dsa/mv88e6xxx.h | 5 +++++
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
> index 49ef2f8..d2beb10 100644
> --- a/drivers/net/dsa/mv88e6xxx.c
> +++ b/drivers/net/dsa/mv88e6xxx.c
> @@ -1686,7 +1686,8 @@ static int mv88e6xxx_setup_port(struct dsa_switch *ds, int port)
> mv88e6xxx_6185_family(ds))
> reg = PORT_CONTROL_IGMP_MLD_SNOOP |
> PORT_CONTROL_USE_TAG | PORT_CONTROL_USE_IP |
> - PORT_CONTROL_STATE_FORWARDING;
> + PORT_CONTROL_STATE_FORWARDING |
> + PORT_CONTROL_EGRESS_FLOODS_NO_UNKNOWN_UNICAST_DA;
> if (dsa_is_cpu_port(ds, port)) {
> if (mv88e6xxx_6095_family(ds) || mv88e6xxx_6185_family(ds))
> reg |= PORT_CONTROL_DSA_TAG;
> diff --git a/drivers/net/dsa/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx.h
> index f4ea66a..412d14e 100644
> --- a/drivers/net/dsa/mv88e6xxx.h
> +++ b/drivers/net/dsa/mv88e6xxx.h
> @@ -117,6 +117,11 @@
> #define PORT_CONTROL_STATE_BLOCKING 0x01
> #define PORT_CONTROL_STATE_LEARNING 0x02
> #define PORT_CONTROL_STATE_FORWARDING 0x03
> +#define PORT_CONTROL_EGRESS_FLOODS_MASK (0x03 << 2)
> +#define PORT_CONTROL_EGRESS_FLOODS_NO_UNKNOWN_ANY_DA (0x00 << 2)
> +#define PORT_CONTROL_EGRESS_FLOODS_NO_UNKNOWN_MULTICAST_DA (0x01 << 2)
> +#define PORT_CONTROL_EGRESS_FLOODS_NO_UNKNOWN_UNICAST_DA (0x02 << 2)
> +#define PORT_CONTROL_EGRESS_FLOODS_ANY_DA (0x03 << 2)
> #define PORT_CONTROL_1 0x05
> #define PORT_BASE_VLAN 0x06
> #define PORT_DEFAULT_VLAN 0x07
>
next prev parent reply other threads:[~2015-06-02 14:21 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 1:27 [RFC 0/9] net: dsa: mv88e6352: add 802.1q VLAN support Vivien Didelot
2015-06-02 1:27 ` [RFC 1/9] net: dsa: add basic support for switchdev obj Vivien Didelot
2015-06-02 1:27 ` [RFC 2/9] net: dsa: add basic support for VLAN operations Vivien Didelot
2015-06-02 6:52 ` Guenter Roeck
2015-06-02 14:42 ` Guenter Roeck
2015-06-03 0:45 ` Vivien Didelot
2015-06-02 1:27 ` [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops Vivien Didelot
2015-06-02 6:50 ` Guenter Roeck
2015-06-02 7:44 ` Scott Feldman
2015-06-02 13:41 ` Guenter Roeck
2015-06-02 13:42 ` Andrew Lunn
2015-06-02 14:47 ` Guenter Roeck
2015-06-02 22:31 ` nolan
2015-06-03 6:53 ` Scott Feldman
2015-06-03 14:44 ` Guenter Roeck
2015-06-03 18:42 ` Florian Fainelli
2015-06-04 18:22 ` nolan
2015-06-03 1:39 ` Vivien Didelot
2015-06-03 2:17 ` Guenter Roeck
2015-06-03 14:56 ` Vivien Didelot
2015-06-03 15:39 ` Guenter Roeck
2015-06-02 13:05 ` Andrew Lunn
2015-06-02 1:27 ` [RFC 4/9] net: dsa: mv88e6352: add support for VLAN Vivien Didelot
2015-06-02 1:27 ` [RFC 5/9] net: dsa: mv88e6352: disable mirroring Vivien Didelot
2015-06-02 14:16 ` Guenter Roeck
2015-06-02 14:53 ` Andrew Lunn
2015-06-03 1:12 ` Vivien Didelot
2015-06-03 2:27 ` Guenter Roeck
2015-06-02 1:27 ` [RFC 6/9] net: dsa: mv88e6352: allow egress of unknown multicast Vivien Didelot
2015-06-02 14:20 ` Guenter Roeck [this message]
2015-06-03 1:52 ` Vivien Didelot
2015-06-09 22:42 ` Vivien Didelot
2015-06-02 1:27 ` [RFC 7/9] net: dsa: mv88e6352: lock CPU port from learning addresses Vivien Didelot
2015-06-02 14:24 ` Guenter Roeck
2015-06-03 1:06 ` Vivien Didelot
2015-06-03 2:24 ` Guenter Roeck
[not found] ` <CAFXsbZo7DAhbUErMfKas_KUtXMHTURgOxwz-GSr=fuAHLWToEQ@mail.gmail.com>
2015-06-03 4:17 ` Guenter Roeck
2015-06-03 20:51 ` Andrew Lunn
2015-06-02 1:27 ` [RFC 8/9] net: dsa: mv88e6352: set port 802.1Q mode to Secure Vivien Didelot
2015-06-02 14:31 ` Guenter Roeck
2015-06-02 23:45 ` Vivien Didelot
2015-06-02 23:28 ` Guenter Roeck
2015-06-02 1:27 ` [RFC 9/9] net: dsa: fix EDSA frame from hwaccel frame Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556DBBC5.5050009@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jerome.oufella@savoirfairelinux.com \
--cc=jiri@resnulli.us \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.