From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752778AbbFCB44 (ORCPT ); Tue, 2 Jun 2015 21:56:56 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:9312 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751564AbbFCB4s (ORCPT ); Tue, 2 Jun 2015 21:56:48 -0400 Message-ID: <556E5EDC.9030209@imgtec.com> Date: Tue, 2 Jun 2015 18:56:44 -0700 From: Leonid Yegoshin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: David Daney , "Maciej W. Rozycki" CC: James Hogan , , , , , Ralf Baechle , , , , "David S. Miller" Subject: Re: [PATCH 1/3] MIPS: R6: Use lightweight SYNC instruction in smp_* memory barriers References: <20150602000818.6668.76632.stgit@ubuntu-yegoshin> <20150602000934.6668.43645.stgit@ubuntu-yegoshin> <556D8A03.9080201@imgtec.com> <556E42BB.4060705@gmail.com> In-Reply-To: <556E42BB.4060705@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.20.3.79] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/02/2015 04:56 PM, David Daney wrote: > On 06/02/2015 09:15 AM, Maciej W. Rozycki wrote: >> On Tue, 2 Jun 2015, James Hogan wrote: >> >>> >>> binutils appears to support the sync_mb, sync_rmb, sync_wmb aliases >>> since version 2.21. Can we safely use them? >> >> I suggest that we don't -- we still officially support binutils >> 2.12 and >> have other places where we even use `.word' to insert instructions >> current >> versions of binutils properly handle. It may be worth noting in a >> comment >> though that these encodings correspond to these operations that you >> named. >> > > Surely the other MIPSr6 instructions are not supported in binutils > 2.12 either. So if it is for r6, why not require modern tools, and > put something user readable in here? > > No, it can be used for MIPS R2 also. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:59916 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27006820AbbFCB4wrrd8s (ORCPT ); Wed, 3 Jun 2015 03:56:52 +0200 Message-ID: <556E5EDC.9030209@imgtec.com> Date: Tue, 2 Jun 2015 18:56:44 -0700 From: Leonid Yegoshin MIME-Version: 1.0 Subject: Re: [PATCH 1/3] MIPS: R6: Use lightweight SYNC instruction in smp_* memory barriers References: <20150602000818.6668.76632.stgit@ubuntu-yegoshin> <20150602000934.6668.43645.stgit@ubuntu-yegoshin> <556D8A03.9080201@imgtec.com> <556E42BB.4060705@gmail.com> In-Reply-To: <556E42BB.4060705@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: David Daney , "Maciej W. Rozycki" Cc: James Hogan , linux-mips@linux-mips.org, benh@kernel.crashing.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, Ralf Baechle , markos.chandras@imgtec.com, Steven.Hill@imgtec.com, alexander.h.duyck@redhat.com, "David S. Miller" Message-ID: <20150603015644.c88a6tFq9qbhRfUUIU7nS2H4i38gA4rfn1VxTCCoqTg@z> On 06/02/2015 04:56 PM, David Daney wrote: > On 06/02/2015 09:15 AM, Maciej W. Rozycki wrote: >> On Tue, 2 Jun 2015, James Hogan wrote: >> >>> >>> binutils appears to support the sync_mb, sync_rmb, sync_wmb aliases >>> since version 2.21. Can we safely use them? >> >> I suggest that we don't -- we still officially support binutils >> 2.12 and >> have other places where we even use `.word' to insert instructions >> current >> versions of binutils properly handle. It may be worth noting in a >> comment >> though that these encodings correspond to these operations that you >> named. >> > > Surely the other MIPSr6 instructions are not supported in binutils > 2.12 either. So if it is for r6, why not require modern tools, and > put something user readable in here? > > No, it can be used for MIPS R2 also.