All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Naveen Nathan" <naveen@lastninja.net>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] doc: improve readability of --rebase-merges in git-rebase
Date: Tue, 12 Nov 2019 08:44:54 +1100	[thread overview]
Message-ID: <556b38ff-a118-43b3-8024-cf6dd97253ff@www.fastmail.com> (raw)
In-Reply-To: <xmqqr22ehjbg.fsf@gitster-ct.c.googlers.com>

> I think the original "to the deprecated `--preserve-merges`" is
> mildly easier to follow than "to `--preserve-merges` (deprecated)".
> 
> The later part of the sentence with this patch does read smoother
> and is a definite improvement.

Thanks Junio.

I've incorporated the suggestion and will submit a new patch shortly.

- Naveen

  reply	other threads:[~2019-11-11 21:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-10  9:59 [PATCH] doc: improve readability of --rebase-merges in git-rebase Naveen Nathan
2019-11-11  8:49 ` Johannes Schindelin
2019-11-11  9:08 ` Junio C Hamano
2019-11-11 21:44   ` Naveen Nathan [this message]
2019-11-11 23:21   ` [PATCH v2] " Naveen Nathan
2019-11-12  4:18     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556b38ff-a118-43b3-8024-cf6dd97253ff@www.fastmail.com \
    --to=naveen@lastninja.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.