From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
QEMU Trivial <qemu-trivial@nongnu.org>,
Eduardo Otubo <otubo@redhat.com>,
Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PULL 00/31] Trivial patches for 2017-09-25
Date: Tue, 26 Sep 2017 08:57:00 +0300 [thread overview]
Message-ID: <55782343-4bb4-d5ed-2c5d-4dd0fc5764dd@msgid.tls.msk.ru> (raw)
In-Reply-To: <CAFEAcA9GtLniZNyO7Uv=vL9HiSBGjvWRYdR-Zi1E+W4N9qiB6A@mail.gmail.com>
26.09.2017 02:22, Peter Maydell wrote:
[]
>> trivial patches for 2017-09-25
>
> This fails 'make check' on most of my configs:
>
> GTESTER check-qtest-ppc64
> qemu-system-ppc64: -object
> filter-mirror,id=qtest-f0,netdev=qtest-bn0,queue=tx,outdev=mirror0:
> Device 'qtest-bn0' not found
> Broken pipe
> GTester: last random seed: R02Sb816ff80b7d08ef6a5328ff373d8cd65
>
> GLib-CRITICAL **: void g_hook_destroy_link(GHookList *, GHook *):
> assertion `hook != NULL' failed
> aborting...
For what it's worth, this time I just _forgot_ to run tests. What a shame..
It fails due to:
Author: Eduardo Otubo <otubo@redhat.com>
Date: Mon Aug 21 17:50:05 2017 +0200
filter-mirror: segfault when specifying non existent device
When using filter-mirror like the example below where the interface
'ndev0' does not exist on the host, QEMU crashes into segmentation
fault.
$ qemu-system-x86_64 -S -machine pc -netdev user,id=ndev0 -object filter-mirror,id=test-object,netdev=ndev0
This happens because the function filter_mirror_setup() does not checks
if the device actually exists and still keep on processing calling
qemu_chr_find(). This patch fixes this issue.
Signed-off-by: Eduardo Otubo <otubo@redhat.com>
Reviewed-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
Reverting this patch makes it run again. Cc'ing Eduardo.
I'll remove this patch, patch "hw/isa/pc87312: Mark the device with
user_creatable = false" (will be replaced with a better variant),
and update another patch stripping one more trailing whitespace,
and resend.
Thanks,
/mjt
next prev parent reply other threads:[~2017-09-26 5:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 21:22 [Qemu-devel] [PULL 00/31] Trivial patches for 2017-09-25 Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 01/31] configure: Remove unused code (found by shellcheck) Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 02/31] Replace round_page() with TARGET_PAGE_ALIGN() Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 03/31] MAINTAINERS: add missing ARM entries Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 04/31] MAINTAINERS: add missing STM32 entry Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 05/31] MAINTAINERS: add missing entry for vhost Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 06/31] MAINTAINERS: add missing VMWare entry Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 07/31] MAINTAINERS: add missing Guest Agent entries Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 08/31] MAINTAINERS: add missing qcow2 entry Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 09/31] MAINTAINERS: add missing PCI entries Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 10/31] MAINTAINERS: add missing SSI entries Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 11/31] MAINTAINERS: add missing entries for throttling infra Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 12/31] MAINTAINERS: add missing AIO entry Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 13/31] MAINTAINERS: add missing entry for Generic Loader Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 14/31] MAINTAINERS: add missing Cryptography entry Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 15/31] MAINTAINERS: update docs/devel/ entries Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 16/31] MAINTAINERS: update docs/interop/ entries Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 17/31] filter-mirror: segfault when specifying non existent device Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 18/31] util/qemu-thread-posix.c: Replace OS ifdefs with CONFIG_HAVE_SEM_TIMEDWAIT Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 19/31] aux-to-i2c-bridge: don't allow user to create one Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 20/31] hw/display/xenfb.c: Add trace_xenfb_key_event Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 21/31] remove trailing whitespace from qemu-options.hx Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 22/31] chardev/baum: fix baum that releases brlapi twice Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 23/31] trivial: Add missing "-m" parameter in docs/memory-hotplug.txt Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 24/31] target/xtensa: Use the pre-defined MEMTXATTRS_UNSPECIFIED macro Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 25/31] osdep: Fix ROUND_UP(64-bit, 32-bit) Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 26/31] hw/display/virtio-gpu: Put the virtio-gpu-device into the display category Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 27/31] nbd-client: Use correct macro parenthesization Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 28/31] dma/i82374: avoid double creation of i82374 device Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 29/31] tests/boot-sector: Increase timeout to 600 seconds Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 30/31] Drop gld linker usage on SunOS Michael Tokarev
2017-09-24 21:22 ` [Qemu-devel] [PULL 31/31] hw/isa/pc87312: Mark the device with user_creatable = false Michael Tokarev
2017-09-25 23:22 ` [Qemu-devel] [PULL 00/31] Trivial patches for 2017-09-25 Peter Maydell
2017-09-26 5:57 ` Michael Tokarev [this message]
2017-09-26 7:48 ` Eduardo Otubo
[not found] ` <55782343-4bb4-d5ed-2c5d-4dd0fc5764dd@tls.msk.ru>
2017-09-26 6:00 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55782343-4bb4-d5ed-2c5d-4dd0fc5764dd@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=otubo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhangchen.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.