From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2myo-0007WL-Gb for qemu-devel@nongnu.org; Wed, 10 Jun 2015 16:52:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2myn-0000nD-88 for qemu-devel@nongnu.org; Wed, 10 Jun 2015 16:52:10 -0400 Message-ID: <5578A371.2060602@redhat.com> Date: Wed, 10 Jun 2015 14:52:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <1433957094-8303-1-git-send-email-jsnow@redhat.com> In-Reply-To: <1433957094-8303-1-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LoQfQ0pfwM0j104LNUrFAM9tkokgx3pri" Subject: Re: [Qemu-devel] [PATCH] block: Change bitmap truncate conditional to assertion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LoQfQ0pfwM0j104LNUrFAM9tkokgx3pri Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/10/2015 11:24 AM, John Snow wrote: > Requires: 1433796555-5608-1-git-send-email-jsnow@redhat.com > [PATCH] block: record new size in bdrv_dirty_bitmap_truncate >=20 Shouldn't this be after the '---' separator? > This is an artifact of an older version that had both all-bitmap and > single-bitmap truncate functions, and some info got lost in the shuffle= =2E >=20 > Bitmaps can only be frozen during a backup operation, and a backup > operation should prevent a resize operation, so just assert that this > cannot happen. >=20 > Suggested-by: Kevin Wolf > Signed-off-by: John Snow > --- > block.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LoQfQ0pfwM0j104LNUrFAM9tkokgx3pri Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVeKNxAAoJEKeha0olJ0NqyMMIAIwRekTvk6eimup2d28DxWku 3ZBIX3lAnZ0bXZbi7MW4356CAPfstIYfl98jGfwgqPRqmqYCQm8HpZP1H0NiONxe Hi5HgOUa6ZpHHoMSu7LUXEGr9k/yrk+s6U9n2Mrb70WG3mT93zUnPoZiz/FvwM38 iFqwFyPkNxKCiH5ppzj9UtBDG8MHA7x2AWGFwZFoGpiEMJpIKZCUTlXLJYv1aIf0 NXF0bzcvas3fIODadONEL/4UKsGBn6fNc9KG/ngr2YItrTB0lZBbQP7dTT7umTGx KXMa1Q4gsYwtjjJtwovPPYY8zb/Q5x19ip1VVsyV06JyFDrwmKB4Nc+R3BztfCo= =tREp -----END PGP SIGNATURE----- --LoQfQ0pfwM0j104LNUrFAM9tkokgx3pri--