From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2n1k-0000BV-6P for qemu-devel@nongnu.org; Wed, 10 Jun 2015 16:55:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2n1j-0002Md-4n for qemu-devel@nongnu.org; Wed, 10 Jun 2015 16:55:12 -0400 Message-ID: <5578A428.7080001@redhat.com> Date: Wed, 10 Jun 2015 16:55:04 -0400 From: John Snow MIME-Version: 1.0 References: <1433957094-8303-1-git-send-email-jsnow@redhat.com> <5578A371.2060602@redhat.com> In-Reply-To: <5578A371.2060602@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: Change bitmap truncate conditional to assertion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-block@nongnu.org Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, qemu-devel@nongnu.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 06/10/2015 04:52 PM, Eric Blake wrote: > On 06/10/2015 11:24 AM, John Snow wrote: >> Requires: 1433796555-5608-1-git-send-email-jsnow@redhat.com >> [PATCH] block: record new size in bdrv_dirty_bitmap_truncate >> > > Shouldn't this be after the '---' separator? > Sorry, not used to sending single patches without a cover letter. Kevin: If it's not inconvenient for you to do, please delete these lines on commit. >> This is an artifact of an older version that had both all-bitmap >> and single-bitmap truncate functions, and some info got lost in >> the shuffle. >> >> Bitmaps can only be frozen during a backup operation, and a >> backup operation should prevent a resize operation, so just >> assert that this cannot happen. >> >> Suggested-by: Kevin Wolf Signed-off-by: John >> Snow --- block.c | 4 +--- 1 file changed, 1 >> insertion(+), 3 deletions(-) > > Reviewed-by: Eric Blake > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVeKQoAAoJEH3vgQaq/DkO4bAQAIDn75jog313WnsmZ7uRPNQ3 qhCOGUjr4e2S80k7o/blQjXm8eZZjijBPPCmqT68uX5JI9JXcuMRCkbALGSzI7nt U4GidZWYd+D1G97DYfDCpEeKmaRLgoG8OOxnuUIGZIAmmf8NMlTFtNczFeFNwzWC LhVh+aQHyoxsDlIrkHPDyMcGm0LTZ5aWsOx/FhaRjKP0pEm6bAav7pxovjlxsc1R GyVch0wpOyqppKmvaZ3tQGMPCQksoLGSBrAG6q89Ip9LsdFcPphUg0Wee1RMgrbx zKOaI5+vA8dOTpVZqQ03/AOnJLUwgaePupDn9L03LXrmrKDbVV9huUes+aUfyNnM iGdmQRtmQfjQKa0svCsRqtgzPoCNnnDDvuPcSzVFj8+hU01zqnf29peS8bSkTqeW xPoTiIp2+lfmegd2Va/NYoVk+qQo5iDGZshTtjRhkGx5tqKt6RikZT7f3UTPeG8i 1PZM9k6J9zAtrjHyBHwrWo+naFSDwl0iXwtxj/NjZ0nyiLE4yCq5ucWQowITpSin qh8KDLuMP0zCXDSdfQAiO/adxAisiVcOXSomdGJKmY/DiU9wkFYKT3paicASplky /X8DN4Gs0dKx93wl0NDGMTO4+i8KE7uC1HBuFE7YomFYexWGQ7EBPqjb7RyFsSjq il//J7BQPXDhkwId1jHF =ck4X -----END PGP SIGNATURE-----