From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752071AbbFKHhx (ORCPT ); Thu, 11 Jun 2015 03:37:53 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:44928 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752054AbbFKHhq (ORCPT ); Thu, 11 Jun 2015 03:37:46 -0400 Message-ID: <55793ABB.5050302@st.com> Date: Thu, 11 Jun 2015 09:37:31 +0200 From: Gabriel Fernandez User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: , , CC: , , , Peter Griffin Subject: Re: [PATCH 4/6] clk: st: make use of of_clk_parent_fill helper function References: <1433972965-24974-1-git-send-email-dinguyen@opensource.altera.com> <1433972965-24974-5-git-send-email-dinguyen@opensource.altera.com> In-Reply-To: <1433972965-24974-5-git-send-email-dinguyen@opensource.altera.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.254.84] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-06-11_04:2015-06-10,2015-06-11,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tested-by Gabriel Fernandez Best Regards. On 06/10/2015 11:49 PM, dinguyen@opensource.altera.com wrote: > From: Dinh Nguyen > > Use of_clk_parent_fill to fill in the parent clock names' array. > > Signed-off-by: Dinh Nguyen > Cc: Peter Griffin > Cc: Gabriel FERNANDEZ > --- > drivers/clk/st/clk-flexgen.c | 6 ++---- > drivers/clk/st/clkgen-mux.c | 7 ++----- > 2 files changed, 4 insertions(+), 9 deletions(-) > > diff --git a/drivers/clk/st/clk-flexgen.c b/drivers/clk/st/clk-flexgen.c > index 657ca14..ed0696c 100644 > --- a/drivers/clk/st/clk-flexgen.c > +++ b/drivers/clk/st/clk-flexgen.c > @@ -243,7 +243,7 @@ static const char ** __init flexgen_get_parents(struct device_node *np, > int *num_parents) > { > const char **parents; > - int nparents, i; > + int nparents; > > nparents = of_clk_get_parent_count(np); > if (WARN_ON(nparents <= 0)) > @@ -253,10 +253,8 @@ static const char ** __init flexgen_get_parents(struct device_node *np, > if (!parents) > return NULL; > > - for (i = 0; i < nparents; i++) > - parents[i] = of_clk_get_parent_name(np, i); > + *num_parents = of_clk_parent_fill(np, parents, nparents); > > - *num_parents = nparents; > return parents; > } > > diff --git a/drivers/clk/st/clkgen-mux.c b/drivers/clk/st/clkgen-mux.c > index 4fbe6e0..b83654a 100644 > --- a/drivers/clk/st/clkgen-mux.c > +++ b/drivers/clk/st/clkgen-mux.c > @@ -24,7 +24,7 @@ static const char ** __init clkgen_mux_get_parents(struct device_node *np, > int *num_parents) > { > const char **parents; > - int nparents, i; > + int nparents; > > nparents = of_clk_get_parent_count(np); > if (WARN_ON(nparents <= 0)) > @@ -34,10 +34,7 @@ static const char ** __init clkgen_mux_get_parents(struct device_node *np, > if (!parents) > return ERR_PTR(-ENOMEM); > > - for (i = 0; i < nparents; i++) > - parents[i] = of_clk_get_parent_name(np, i); > - > - *num_parents = nparents; > + *num_parents = of_clk_parent_fill(np, parents, nparents); > return parents; > } >