From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751621AbbFKHvY (ORCPT <rfc822;w@1wt.eu>);
	Thu, 11 Jun 2015 03:51:24 -0400
Received: from mail-wg0-f48.google.com ([74.125.82.48]:32803 "EHLO
	mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750825AbbFKHvP (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 11 Jun 2015 03:51:15 -0400
Message-ID: <55793DF0.1000406@suse.cz>
Date: Thu, 11 Jun 2015 09:51:12 +0200
From: Jiri Slaby <jslaby@suse.cz>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Dan Williams <dan.j.williams@intel.com>, axboe@kernel.dk
CC: Keith Busch <keith.busch@intel.com>, neilb@suse.de,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH -stable] block: fix ext_dev_lock lockdep report
References: <20150611034540.15034.24413.stgit@dwillia2-desk3.amr.corp.intel.com>
In-Reply-To: <20150611034540.15034.24413.stgit@dwillia2-desk3.amr.corp.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/11/2015, 05:47 AM, Dan Williams wrote:
>  =================================
>  [ INFO: inconsistent lock state ]
>  4.1.0-rc7+ #217 Tainted: G           O
>  ---------------------------------
>  inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage.
>  swapper/6/0 [HC0[0]:SC1[1]:HE1:SE0] takes:
>   (ext_devt_lock){+.?...}, at: [<ffffffff8143a60c>] blk_free_devt+0x3c/0x70
>  {SOFTIRQ-ON-W} state was registered at:
>    [<ffffffff810bf6b1>] __lock_acquire+0x461/0x1e70
>    [<ffffffff810c1947>] lock_acquire+0xb7/0x290
>    [<ffffffff818ac3a8>] _raw_spin_lock+0x38/0x50
>    [<ffffffff8143a07d>] blk_alloc_devt+0x6d/0xd0  <-- take the lock in process context
> [..]
>   [<ffffffff810bf64e>] __lock_acquire+0x3fe/0x1e70
>   [<ffffffff810c00ad>] ? __lock_acquire+0xe5d/0x1e70
>   [<ffffffff810c1947>] lock_acquire+0xb7/0x290
>   [<ffffffff8143a60c>] ? blk_free_devt+0x3c/0x70
>   [<ffffffff818ac3a8>] _raw_spin_lock+0x38/0x50
>   [<ffffffff8143a60c>] ? blk_free_devt+0x3c/0x70
>   [<ffffffff8143a60c>] blk_free_devt+0x3c/0x70    <-- take the lock in softirq
>   [<ffffffff8143bfec>] part_release+0x1c/0x50
>   [<ffffffff8158edf6>] device_release+0x36/0xb0
>   [<ffffffff8145ac2b>] kobject_cleanup+0x7b/0x1a0
>   [<ffffffff8145aad0>] kobject_put+0x30/0x70
>   [<ffffffff8158f147>] put_device+0x17/0x20
>   [<ffffffff8143c29c>] delete_partition_rcu_cb+0x16c/0x180
>   [<ffffffff8143c130>] ? read_dev_sector+0xa0/0xa0
>   [<ffffffff810e0e0f>] rcu_process_callbacks+0x2ff/0xa90
>   [<ffffffff810e0dcf>] ? rcu_process_callbacks+0x2bf/0xa90
>   [<ffffffff81067e2e>] __do_softirq+0xde/0x600
> 
> Neil sees this in his tests and it also triggers on pmem driver unbind
> for the libnvdimm tests.  This fix is on top of an initial fix by Keith
> for incorrect usage of mutex_lock() in this path: 2da78092dda1 "block:
> Fix dev_t minor allocation lifetime".  Both this and 2da78092dda1 are
> candidates for -stable.

And what is *this* in terms of SHA? Thanks.

> Fixes: 2da78092dda1 ("block: Fix dev_t minor allocation lifetime")
> Cc: <stable@vger.kernel.org>
> Cc: Keith Busch <keith.busch@intel.com>
> Reported-by: NeilBrown <neilb@suse.de>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> 
> Note that 2da78092dda1 had "Cc: stable@kernel.org" instead of @vger.kernel.org.



-- 
js
suse labs