From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755090AbbFKUCc (ORCPT ); Thu, 11 Jun 2015 16:02:32 -0400 Received: from mail-bl2on0093.outbound.protection.outlook.com ([65.55.169.93]:48576 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751399AbbFKUC1 (ORCPT ); Thu, 11 Jun 2015 16:02:27 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; elopez.com.ar; dkim=none (message not signed) header.d=none; Authentication-Results: elopez.com.ar; dkim=none (message not signed) header.d=none; Message-ID: <5579E7BD.8010908@opensource.altera.com> Date: Thu, 11 Jun 2015 14:55:41 -0500 From: Dinh Nguyen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Maxime Ripard CC: , , , , , =?windows-1252?Q?Emilio_L=F3pez?= Subject: Re: [PATCH 5/6] clk: sunxi: make use of of_clk_parent_fill helper function References: <1433972965-24974-1-git-send-email-dinguyen@opensource.altera.com> <1433972965-24974-6-git-send-email-dinguyen@opensource.altera.com> <20150611090653.GH19653@lukather> In-Reply-To: <20150611090653.GH19653@lukather> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BN1PR02CA0034.namprd02.prod.outlook.com (10.141.56.34) To CY1PR03MB1374.namprd03.prod.outlook.com (25.163.16.28) X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1374;2:lOa+QGRvkUDq0Xz+UeuGO2969DPVGOpmSBgHGqih6Dq8KS2iqNAzGUdOdHydTVkT;2:+fYFw+k8852tDkJLTvwwXWcvxLNVig8PzanO7MF5kJrkPZnI446Dgh0kST2yLWLd9hqt7ppf/9AGqys8Qf7qg0/hHUlr3K3a9hGEYzEqcAeO+KV3R1oWnWxZvnxpHxQmFik55QiQsAd9w2yY9OSwbg==;6:Hs2fNsvVQIcSVzG3NdBmzekuM0S8GbEPRJPjS5u5ZB9TiQOuS5fekbcnKtrlQXTYy9iD99Gph+7lzt2gza+xEqaNF1hxEy1KuV0eA5/rOCl4RI/5iya/eeORgCMX24NFy/Gmqwn5mhJYOckknYwSBw==;3:+ZIs6doePfmrVlGJReQAlxzYp9d2GmVYKC720Pphot3bvS+9/44AidpRYYSpa6ymtS/X6xTAm4C2KpR15BOqik7BTM12MLqXPf+QV+srgUHqOeD2bGV5oFL6L7y/cpHV+f08ftHlgGKfIAe1LWoZy8Bt931pLO0+Mpyb5QAGattCvRz1hOJIbT0ba5AZxnv1i1anEorQ6TJ/0Vcs/QEr8kzbvCsBh+hzBWtxbiIY/SEalV1wGI2lqFzm52RQNK51mCyD4QO5Pmv7yd1IH/7jmA2p2wOUWbGp7dXe3tCf5WWVY62j/mShNGkBG/B2TrOe X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1374;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB290; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:CY1PR03MB1374;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1374;BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BL2PR03MB290;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB290; X-Forefront-PRVS: 0604AFA86B X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(479174004)(24454002)(51704005)(164054003)(377454003)(77096005)(59896002)(64126003)(62966003)(77156002)(4001350100001)(2950100001)(66066001)(65956001)(47776003)(46102003)(33656002)(40100003)(122386002)(86362001)(92566002)(87976001)(23746002)(42186005)(189998001)(5001920100001)(83506001)(5001960100002)(50986999)(19580395003)(54356999)(76176999)(19580405001)(87266999);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR03MB1374;H:[137.57.160.210];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?Windows-1252?Q?1;CY1PR03MB1374;9:UyJHFhJClSfzHb98VGUVv05sQpH7uHawQmlxWd?= =?Windows-1252?Q?tsytvt5dIC2r/eXG8Jg+nbSZmA+Qr8ws045dn0M9NL4pXEMeRfu3DnEr?= =?Windows-1252?Q?UACAzhC1tPU6TuugTApraTCniRJGopeNV6HSbOsAcVsyM9uUBIm2ZABQ?= =?Windows-1252?Q?AzbsuFZWfFPsmmPlcebPJ7uMXV/nWuXo1xSBgLTye2NW4FF6EveV93sp?= =?Windows-1252?Q?+9Ze2x1nprsjupa4umqiH7ZnfuomGvOR28+7kE0E3zt5bkxaEUKmn2kG?= =?Windows-1252?Q?gYxm4LkSYzJ/7+ZIVx1L4ghaLOrDaPqlq7VFrJB/CpqHAg1SA5l0odGr?= =?Windows-1252?Q?GGZnsUU/6iCYxsf9szG3uok8HYMxMdZhCknK9dNbqIf3o5ufZwqqKpnE?= =?Windows-1252?Q?rD6Y3eI51aCwOCVnd5vdxqeWMBAX5l6bmDST9CZvk9PZs/MO2Tf2/Vfh?= =?Windows-1252?Q?e8e9mgn7KALaVlU9ZNeXR525ewFYNUaGtpxNbXa2ZU0DwbmgOMlf2pT2?= =?Windows-1252?Q?d5p6SqLcpyNQpjChO2Wtbqg8Tjqd+0NpP/QDhEOIuA6HNk3yyYFiX7dN?= =?Windows-1252?Q?PCjaeL16pvvt3g74m/NmzL7Vfn64oWZ5aRLuDJKOtwxRyuOsRPzFLSmX?= =?Windows-1252?Q?pJi6TZNSm1Pfzbegc8QRxpPAXouTYusDAx3WJ+SUfTGUUyrPBP3uH1G+?= =?Windows-1252?Q?e2pjkt3+KwdhVUv5DX7KGUFP/c75KJrYFTn01NQ2PWqomRL6Wz5DyrAj?= =?Windows-1252?Q?6L8CbMN+8MrjV2Ou9xPzC5g8tN1UDzLlE8Wv8kpcxWHZquWcpDLU/a3p?= =?Windows-1252?Q?mcldlqukZO/ZuznQRhi0QPkh8inaJ77BRzqxqNaVKOxFb3dEIFmlaYEH?= =?Windows-1252?Q?u4c10d2xjM6DPEKdT8P3Uw6rAp2wAvrofwl8rNfXTeZnyiYyU6e9AjDy?= =?Windows-1252?Q?0ng5hL1WsfEPK78qk5LfefXifoHBhRvPiFqWFJ4TJqASFcUEVLWMixi7?= =?Windows-1252?Q?Z00GswsPIgAPxWtkzifbXs43nmxXGHCqjSN1tjEXEu3V2OWA=3D=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1374;3:Ub3RM09kVk1BXf2e1Ac0t/Mvpby1NH5pPxg7j+I8tkqvybdtnpeNakHjUZilC7JgqjAUCZNX+5HWa/GVKimargbIkyNe7bUYtmFWq3VUM64ayaukQBTMYCOw8QlG6t0zOd4MuzPBFBzyJuz8wHNLiA==;10:JhobnChUhVszQR/OAZqwek2Xo0QxXmxNiBJ5Cg2Ik+HmNjfbNx0l8/S11hvK5ECEbAVnsuGg0xFDXTCeH8ZN3Rw6C6jQBhwvOc25DoOIm4Y=;6:taToY1ugXAxAar9MixgS83dxZ/1UtmFpnlWcmP5Jh4U2ecw7DDfQdAOceksRZR5ZKPwRbMdPOQ6ZuNaeb0FbeehmrTS2NAhnDvbHJLQM8lhifppnMHcUMcWERt4Uieo6BzArPu/o8sqtS7rHgjFupw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1374 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1AFFO11FD056.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD056;1:IXFiUSLplnQh79dmwsD4G4GuHq2p28aP9jafzF/naC733uOmhjG2qecu3G6KtWHtmXXO3sGs+AVxmOJiOFqIcyumjfwA8h58BHsvnn/AgyvcfqiNWPiTGJzJ7gFNplMlJdXLdcuwOYyMfXMSVTq9kbkU5TUeM8zFXAHC2vE63QB5PXpzOtjBXARhIrZjoFH3yF1Et5y3dyDVUTP8eQ8TNWA+10N7r/IYZOlGVI03R9jPhV0zcgSE9Ws8Tel8OIQU3+QZZknhBeu7I8uuV1N60Ltxnf2o56jXHaMkQ+FY78/MjIqFjJ9EmRKBSte2FDj9juXDQlh0307bZ7zb8KMKgQ== X-Forefront-Antispam-Report: CIP:66.35.236.236;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(339900001)(199003)(189002)(51704005)(479174004)(164054003)(24454002)(377454003)(59896002)(46102003)(23746002)(85426001)(83506001)(65816999)(64126003)(76176999)(65956001)(50986999)(106466001)(54356999)(16796002)(87266999)(19580395003)(4001350100001)(62966003)(87936001)(2950100001)(19580405001)(50466002)(77156002)(80316001)(5001920100001)(122386002)(5001960100002)(110136002)(47776003)(86362001)(40100003)(92566002)(90366008)(33656002)(105606002)(66066001)(65806001)(77096005)(189998001)(6806004)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2PR03MB290;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;MLV:ovrnspm;A:0;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB290;2:MPahR71LmFg/6gamPGkl13TYVDMFjPBg+b0YdeHBHbD9LfuV1FDcmU8vqAVvDdh8;2:IUhWAwLctx9r4L1LkyBqYBguVDlVeUfY72ksO0kt2HA+5kFHKLI/Enfx+iuKWlmXYwRH7ZnKJBVQxSKwfGGwWmyMP2hyEhEvbDr6lBPec1GG8mnayqTVb8zGGSfQR4BoWo9+zvAhmLRZypyw7Ur+4yFbi6WK+HN/7HBVAvTAeu0SeSvQzZr9JkunmL/HoI/8BRPcsV7YbKlzx25OV42wyE732Vws4Zxccrtd2wJbOOQ=;6:nYJORwWq4aq61z2phrvHRk9w1QuodqwaRHOBRYasT/oDwYjEMeO7g3XG2vz6kmX7TJoesnHBULuo8QubVzG/hZs11kdvYHgSazYb6j7DtQKAq8c7U0sHQ7lz+yidLHg1uuDgIZkTcfX/9mVA6gDdCQ==;3:hbWlmFcpmtKhOC9ZiEsK6XFHngqJVGFE7JXr+Ku9GY+Z21wnggbbyaACiVYlB7st9ApTwKLZGdCx9oaf7s/JEMPPQLjeERuV1NAhxPS+IXs/dkTux6Q5yYov3Q2tdgt2mehzXg0zGy0wpuPKljIX/JbInamzCIrX17tyghWjn9w0Kmiyo93VN3vIsTwVCXgIzZDksaDI/GbrN7/l9e45byoU8xDS7Ca9bw5Djqbo8Mh1v0YabedqD2bxieF9fD6TMxWSe5Y435RQh3JejjNlTFUVX/9SF71PWeh8wijxPZARkms2ObR2xnozSQzIItz5 X-Forefront-PRVS: 0604AFA86B X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BL2PR03MB290;9:PRrv4P7uqDclxaNAHmG9JYjdlirR0pOsDBQuaYO?= =?Windows-1252?Q?b/qD4QykvTC/BoAAdfsFRETRboKXHOfDzjNo78jqbVVK+lkYxij9Q/DD?= =?Windows-1252?Q?IFQfZx4FRVwNEUtJv5K2sZQaFyGKNgZro+a6Tm+4Rbcb7gvjRIRdzLDE?= =?Windows-1252?Q?NfJeefALNVCjcyLGL/LtZK2Z858huIFyq3RiG672HiBnzzv4ii5DcpZw?= =?Windows-1252?Q?3q0ZqC3+SwUJrK8nQwbUiQzvWuHOV68mJuUwLCOVnxmSDLL/txzzMrZT?= =?Windows-1252?Q?3d2VOKCjYWLeM/JFDzIUHIMWBmMKSG+xEIZxxv1KrIqpiiWihwah8BiM?= =?Windows-1252?Q?MkkJA8QM4LdNdkZlUTTtpt1/0VXZKUNtX419MlbO3GDgJxdcTTtJ1hdF?= =?Windows-1252?Q?ON7h8F/PQNOnECoSCWBB6UKc8wuKL+ZduGhZBjg2iQ2nDSS0f3Ma+w7c?= =?Windows-1252?Q?6UQc3WenKqvAhBde5/Qk6P5UOwkzmpEzEzpdHIdO14wLKa38WKB/9a3l?= =?Windows-1252?Q?fIp+lll83d7ccB1gFwrAX9Y3FhUxMYY1Pc+aIE+fVrpuwh7aVTusToWg?= =?Windows-1252?Q?GTVrj97KULTvebnY6bNL3RMQytg9uwqh5LZX8BvzcYtNLMGXcncMFhLQ?= =?Windows-1252?Q?C/3i4uwWcO9jV9VeWbB+BLOUjCUtTCiOr+NJFFOR9X/IZ0l1VBHPbv7b?= =?Windows-1252?Q?Pofyd1anjRVHM0sGqr++H9NMn9vx4PP4myjEgUsYSAaPA3KQLwWuWAFf?= =?Windows-1252?Q?Fq/CMQZOaYj4+wUEbHEgib9EwIwbhJkV8UVb1UFyzXmpI4Vgm+jS/wIB?= =?Windows-1252?Q?ZlSpA0d2rwSRundg++LzrZmVuy2INr71dZ1A5BX2kZPgQriz/8vdEwxm?= =?Windows-1252?Q?GZN2BrKXvaeCbL4oh2x7QmRUC+Xur8XgXHiouvh1plaqgJW0QvlqTdim?= =?Windows-1252?Q?lDQV8Fgw8/HTsZXqigpCKZccu37YPJLyo5MKx/7XfFd+JuuiRui6Fm0T?= =?Windows-1252?Q?aoEhAg9ZZeelo+dk4h0kKOHBCy/D8xPlotLD1+F86B7JNyN5nGWphvf+?= =?Windows-1252?Q?ymABmrKgqyQEcacrLfgQ6FD76/csMr+YKRpdWytAf3grK/MCDce0ccS3?= =?Windows-1252?Q?9dS1QthfV38WC/yRxKom/+Bv6Hegxkoc/k5ALMQcb27ioAsZaX9O/FbO?= =?Windows-1252?Q?3/FZr8z0IIsagYU3Joch8+7JDDGOpaymK8PFvlcdHb26sR08n6yifOcB?= =?Windows-1252?Q?vbKq+pGm4DvvAuXg8dOz9H4a7xNR3JXuR84iv2jKmHfD+ZxxZtNNQQkP?= =?Windows-1252?Q?ye2kl+x1jb9yBvG2bLsNDnaRx34METBDNAKnJzxsCrKg=3D?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB290;3:dgeN1NWA9VOLFtbYGLVPecePTUOcdeRErWaBy3fCbMqLYVwg0F3MYw37bvDO1nGFk/GJNBFUDNdKcWl8RZlaLYZDcGN7e43QorFiFMd0ngHQEYDd2HQO+HiU49oB5y0oTZsaHh8hL5PXdafIaOt3Lg==;10:UNKCnj1avyGQiHSih7RjHPwZY9PBO1VVqE/JcIZogQI2pM8Vcka0F+jEJpvLTYEHfqTs6Hc2/XkY7//dsvEwvzkiYhOZ+bi121jNV0xWDR0=;6:0L1seOo3mxdkuchlnOD5CkIWar4M7HAalr8VvL29EUCFczDerFWETObwz79SBlzv5/lQjTkXRp88qaQCufIDTI/DuUU1utuo1GBRhXmrnJ8MZMjClR7ySCN1sFTQst/XMucFyHWKUQ+UPh25TX0gUQ== X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2015 20:02:18.9990 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB290 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/11/2015 04:06 AM, Maxime Ripard wrote: > Hi Dinh, > > On Wed, Jun 10, 2015 at 04:49:24PM -0500, dinguyen@opensource.altera.com wrote: >> From: Dinh Nguyen >> >> Use of_clk_parent_fill to fill in the parent clock names' array. >> >> Signed-off-by: Dinh Nguyen >> Cc: Maxime Ripard >> Cc: "Emilio López" >> --- >> drivers/clk/sunxi/clk-a20-gmac.c | 3 +-- >> drivers/clk/sunxi/clk-factors.c | 4 +--- >> drivers/clk/sunxi/clk-sun6i-ar100.c | 3 +-- >> drivers/clk/sunxi/clk-sunxi.c | 10 ++-------- >> 4 files changed, 5 insertions(+), 15 deletions(-) >> >> diff --git a/drivers/clk/sunxi/clk-a20-gmac.c b/drivers/clk/sunxi/clk-a20-gmac.c >> index 0dcf4f2..a432edd 100644 >> --- a/drivers/clk/sunxi/clk-a20-gmac.c >> +++ b/drivers/clk/sunxi/clk-a20-gmac.c >> @@ -80,8 +80,7 @@ static void __init sun7i_a20_gmac_clk_setup(struct device_node *node) >> goto free_mux; >> >> /* gmac clock requires exactly 2 parents */ >> - parents[0] = of_clk_get_parent_name(node, 0); >> - parents[1] = of_clk_get_parent_name(node, 1); >> + of_clk_parent_fill(node, parents, 2); >> if (!parents[0] || !parents[1]) > > Maybe this check can be changed to something like: > > if (of_clk_parent_fill(node, parents, 2) != 2) > goto free_gate; > > Would that make sense? > Yes, that would work. Will edit for v2. Thanks, Dinh