From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752552AbbFLVLq (ORCPT ); Fri, 12 Jun 2015 17:11:46 -0400 Received: from p01c11o141.mxlogic.net ([208.65.144.64]:60250 "EHLO p01c11o141.mxlogic.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750856AbbFLVLo (ORCPT ); Fri, 12 Jun 2015 17:11:44 -0400 X-Greylist: delayed 482 seconds by postgrey-1.27 at vger.kernel.org; Fri, 12 Jun 2015 17:11:41 EDT X-MXL-Hash: 557b4b0e0d213629-8b80cefdf4d63d8f7c47e2cf3f60bb261664f49e X-MXL-Hash: 557b492a6723dd45-1e9ec6c390b9cc0d29d0728cba5599ef1dfbd103 Message-ID: <557B4923.1020608@stratus.com> Date: Fri, 12 Jun 2015 17:03:31 -0400 From: Joe Lawrence User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Sreekanth Reddy , , CC: , , , , Subject: Re: [PATCH 17/20] [SCSI] mpt3sas: Use alloc_ordered_workqueue() API instead of create_singlethread_workqueue() API References: <1434102153-38581-1-git-send-email-Sreekanth.Reddy@avagotech.com> <1434102153-38581-18-git-send-email-Sreekanth.Reddy@avagotech.com> In-Reply-To: <1434102153-38581-18-git-send-email-Sreekanth.Reddy@avagotech.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [134.111.199.152] X-AnalysisOut: [v=2.1 cv=Z7r4HRhA c=1 sm=1 tr=0 a=o2bo05G+d1rlxuoNbFVhCw==] X-AnalysisOut: [:117 a=o2bo05G+d1rlxuoNbFVhCw==:17 a=KOg_qkMfzZkA:10 a=Cdz] X-AnalysisOut: [KgOd8jloA:10 a=BLceEmwcHowA:10 a=N659UExz7-8A:10 a=uelBKuK] X-AnalysisOut: [pAAAA:8 a=YlVTAMxIAAAA:8 a=XAFQembCKUMA:10 a=iD8xC2Zqx7UrP] X-AnalysisOut: [0OL-qYA:9 a=pILNOxqGKmIA:10 a=x0HXviunenAA:10 a=dpE9LqO0NN] X-AnalysisOut: [QA:10] X-Spam: [F=0.5000000000; CM=0.500; MH=0.500(2015061213); S=0.200(2014051901)] X-MAIL-FROM: X-SOURCE-IP: [134.111.1.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/12/2015 05:42 AM, Sreekanth Reddy wrote: ... > +#if defined(alloc_ordered_workqueue) > + ioc->firmware_event_thread = alloc_ordered_workqueue( > + ioc->firmware_event_name, WQ_MEM_RECLAIM); > +#else > + ioc->firmware_event_thread = create_singlethread_workqueue( > ioc->firmware_event_name); > +#endif Hi Sreekanth, I think the upstream version of this code can safely assume alloc_ordered_workqueue is defined, no? Regards, -- Joe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Lawrence Subject: Re: [PATCH 17/20] [SCSI] mpt3sas: Use alloc_ordered_workqueue() API instead of create_singlethread_workqueue() API Date: Fri, 12 Jun 2015 17:03:31 -0400 Message-ID: <557B4923.1020608@stratus.com> References: <1434102153-38581-1-git-send-email-Sreekanth.Reddy@avagotech.com> <1434102153-38581-18-git-send-email-Sreekanth.Reddy@avagotech.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: Received: from p01c11o141.mxlogic.net ([208.65.144.64]:60250 "EHLO p01c11o141.mxlogic.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750856AbbFLVLo (ORCPT ); Fri, 12 Jun 2015 17:11:44 -0400 In-Reply-To: <1434102153-38581-18-git-send-email-Sreekanth.Reddy@avagotech.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Sreekanth Reddy , jejb@kernel.org, hch@infradead.org Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, JBottomley@Parallels.com, Sathya.Prakash@avagotech.com, linux-kernel@vger.kernel.org On 06/12/2015 05:42 AM, Sreekanth Reddy wrote: ... > +#if defined(alloc_ordered_workqueue) > + ioc->firmware_event_thread = alloc_ordered_workqueue( > + ioc->firmware_event_name, WQ_MEM_RECLAIM); > +#else > + ioc->firmware_event_thread = create_singlethread_workqueue( > ioc->firmware_event_name); > +#endif Hi Sreekanth, I think the upstream version of this code can safely assume alloc_ordered_workqueue is defined, no? Regards, -- Joe