From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3YP5-0005Wf-Ki for qemu-devel@nongnu.org; Fri, 12 Jun 2015 19:30:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3YOz-0002bf-Ko for qemu-devel@nongnu.org; Fri, 12 Jun 2015 19:30:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3YOz-0002bV-FJ for qemu-devel@nongnu.org; Fri, 12 Jun 2015 19:30:21 -0400 Message-ID: <557B6B87.6060802@redhat.com> Date: Fri, 12 Jun 2015 17:30:15 -0600 From: Eric Blake MIME-Version: 1.0 References: <1434120674-8122-1-git-send-email-armbru@redhat.com> <1434120674-8122-8-git-send-email-armbru@redhat.com> In-Reply-To: <1434120674-8122-8-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h42KPamvsEBmT7FkM7u0X2W00nob67rK7" Subject: Re: [Qemu-devel] [PATCH 07/16] qapi: Simplify inclusion cycle detection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --h42KPamvsEBmT7FkM7u0X2W00nob67rK7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/12/2015 08:51 AM, Markus Armbruster wrote: > We maintain a stack of filenames in include_hist for convenient cycle > detection. >=20 > As error_path() demonstrates, the same information is readily > available in the expr_info, so just use that, and drop include_hist. >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) >=20 Yet another parameter gone, and the testsuite proves we don't regress in error message quality. I'm glad I spent time on the testsuite! Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --h42KPamvsEBmT7FkM7u0X2W00nob67rK7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVe2uHAAoJEKeha0olJ0NqaokIAJbw38FLWukFMBze0+09SJnk PaCHuz4w95nuUZ/LwmTq7p+FctuSpQ13mCRI0O4hqvjujMOzjpgcLFCXkeAJrRbD oh4URaDzaER94ABKJzgbcQuCF5wIOPW4GkIPEfqqj9P/Xh8FkQFttPnHK8S/Q7Fc HUT7Y6flJEew31nbm7ORQU273c8HMM5T/qhriJRIAPvkA+A2MJa9NCQbJVo/2E/y 0ufL3pHTf39l79sDmfG+q7wp68HmrFb54mKaImQUvzNUBbCP6IazZYo1qbblS1tA 9hdz2fwt+dmtlkPVlYYLneaIk77iXrB8BBb8cTr2HW/MEsH/yqBvfku+DdDYOaM= =noJR -----END PGP SIGNATURE----- --h42KPamvsEBmT7FkM7u0X2W00nob67rK7--