From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755784AbbFLXtd (ORCPT ); Fri, 12 Jun 2015 19:49:33 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59410 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751850AbbFLXtb (ORCPT ); Fri, 12 Jun 2015 19:49:31 -0400 Message-ID: <557B7008.3010502@codeaurora.org> Date: Fri, 12 Jun 2015 16:49:28 -0700 From: "Zhang, Jonathan Zhixiong" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Ingo Molnar CC: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Matt Fleming , fu.wei@linaro.org, al.stone@linaro.org, bp@alien8.de, tony.luck@gmail.com, ying.huang@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 1/4] x86: acpi: define uncached page flag References: <1434047160-23358-1-git-send-email-zjzhang@codeaurora.org> <1434047160-23358-2-git-send-email-zjzhang@codeaurora.org> <20150612075244.GB8759@gmail.com> In-Reply-To: <20150612075244.GB8759@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/12/2015 12:52 AM, Ingo Molnar wrote: > > * Jonathan (Zhixiong) Zhang wrote: > >> From: "Jonathan (Zhixiong) Zhang" >> >> This definition is used in APEI code when needing to map pages as >> uncached. >> >> Signed-off-by: Jonathan (Zhixiong) Zhang >> --- >> arch/x86/include/asm/acpi.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/x86/include/asm/acpi.h b/arch/x86/include/asm/acpi.h >> index 3a45668f6dc3..6afb27682b00 100644 >> --- a/arch/x86/include/asm/acpi.h >> +++ b/arch/x86/include/asm/acpi.h >> @@ -138,6 +138,10 @@ static inline void disable_acpi(void) { } >> >> #endif /* !CONFIG_ACPI */ >> >> +#ifdef CONFIG_ACPI_APEI >> +#define ARCH_APEI_PAGE_KERNEL_UC (PAGE_KERNEL_NOCACHE) >> +#endif /*CONFIG_ACPI_APEI */ > > - Why the tab? > > - Why the parentheses? > > - Why the closing comment block for a oneliner define? It's not like we forget > what it's about. > > - When the missing space in the closing comment? > > That's 4 uglies in 3 lines of code, wow ... > > Thanks, > > Ingo > Thank you Ingo for the review. I agree that style is important. -- Jonathan (Zhixiong) Zhang The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project