From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:37960 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798AbbFMSGc (ORCPT ); Sat, 13 Jun 2015 14:06:32 -0400 Message-ID: <557C7125.3010606@kernel.org> Date: Sat, 13 Jun 2015 19:06:29 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= , Tiberiu Breana , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald CC: kernel@pengutronix.de, Alexandre Courbot , Linus Walleij , linux-iio@vger.kernel.org Subject: Re: [PATCH] iio: light: stk3310: use flags argument of devm_gpiod_get References: <1434095506-1581-1-git-send-email-u.kleine-koenig@pengutronix.de> In-Reply-To: <1434095506-1581-1-git-send-email-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=utf-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 12/06/15 08:51, Uwe Kleine-König wrote: > Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions) > which appeared in v3.17-rc1, the gpiod_get* functions take an additional > parameter that allows to specify direction and initial value for output. > > Simplify driver accordingly. Furthermore this is one caller less that > stops us making the flags argument to gpiod_get*() mandatory. > > Signed-off-by: Uwe Kleine-König Acked-by: Jonathan Cameron > --- > Hello, > > this patch applies to next and is only necessary on top of 3dd477acbdd1 > (iio: light: Add threshold interrupt support for STK3310) which > currently sits in next. > > Note I plan to make the flags parameter mandatory for 4.3. So unless > this change gets into 4.2, would it be ok to let it go in via the gpio > tree? yes, that's fine. Thanks, Jonathan > > Best regards > Uwe > > drivers/iio/light/stk3310.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c > index e79b9d89b024..504d1e9b4c02 100644 > --- a/drivers/iio/light/stk3310.c > +++ b/drivers/iio/light/stk3310.c > @@ -488,16 +488,12 @@ static int stk3310_gpio_probe(struct i2c_client *client) > dev = &client->dev; > > /* gpio interrupt pin */ > - gpio = devm_gpiod_get_index(dev, STK3310_GPIO, 0); > + gpio = devm_gpiod_get_index(dev, STK3310_GPIO, 0, GPIOD_IN); > if (IS_ERR(gpio)) { > dev_err(dev, "acpi gpio get index failed\n"); > return PTR_ERR(gpio); > } > > - ret = gpiod_direction_input(gpio); > - if (ret) > - return ret; > - > ret = gpiod_to_irq(gpio); > dev_dbg(dev, "GPIO resource, no:%d irq:%d\n", desc_to_gpio(gpio), ret); > >