From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3y7e-0001MR-Mh for qemu-devel@nongnu.org; Sat, 13 Jun 2015 22:58:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3y7b-00062e-Gz for qemu-devel@nongnu.org; Sat, 13 Jun 2015 22:58:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3y7b-00062O-Bb for qemu-devel@nongnu.org; Sat, 13 Jun 2015 22:58:07 -0400 Message-ID: <557CEDB7.1030702@redhat.com> Date: Sat, 13 Jun 2015 20:57:59 -0600 From: Eric Blake MIME-Version: 1.0 References: <1434205258-1932-1-git-send-email-armbru@redhat.com> <1434205258-1932-2-git-send-email-armbru@redhat.com> In-Reply-To: <1434205258-1932-2-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RRcpDpG1swEsG1sE2dTaPpQ1AItB0spu1" Subject: Re: [Qemu-devel] [PATCH 01/11] QemuOpts: Wean off qerror_report_err() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RRcpDpG1swEsG1sE2dTaPpQ1AItB0spu1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/13/2015 08:20 AM, Markus Armbruster wrote: > qerror_report_err() is a transitional interface to help with > converting existing monitor commands to QMP. It should not be used > elsewhere. >=20 > The only remaining user in qemu-option.c is qemu_opts_parse(). Is it > used in QMP context? If not, we can simply replace > qerror_report_err() by error_report_err(). >=20 >=20 > Propoagate errors through qemu_opts_parse(). Create a convenience s/Propoagate/Propagate/ > function qemu_opts_parse_noisily() that passes errors to > error_report_err(). Switch all non-QMP users outside tests to it. >=20 > That leaves vnc_parse_func(). Propagate errors through it. Since I'm > touching it anyway, rename it to vnc_parse(). >=20 > Signed-off-by: Markus Armbruster > --- Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --RRcpDpG1swEsG1sE2dTaPpQ1AItB0spu1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVfO24AAoJEKeha0olJ0Nq6vsH/jlRTZyjP3MNcbmIUEr15qlW OsghoN2NZiiuRRxghK0Tqb6nqfMawPR/yjJcjRkNvXmppIUh6WtMYG88CArbpmrp FxHG78aD8dWMx6IMXW8JgDNT0R9g90RHsfQlpKPYEdZLL+kb7VkuPkecGHItqk9r 7BO4+acE2ClDbhuhc+A1Wji8QCYg/KksAJ6P7w8cLdxufSsu4zRgnXs04k7vu5Bt 7/uFvJnYSmA4/IKrTgoNynKgOfNPdZvja7rHWpD+EaAFP9rHhwELVa+oJg4SQW2x kFh+rbk5kdsmyuVAZw9uutcBX+j6f+TY1oqLiNZeJcUaF+ptsqcxDJ7RNCb+Q4k= =W8bU -----END PGP SIGNATURE----- --RRcpDpG1swEsG1sE2dTaPpQ1AItB0spu1--