From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4TpN-0004vM-0j for qemu-devel@nongnu.org; Mon, 15 Jun 2015 08:49:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4TpI-0000iO-WF for qemu-devel@nongnu.org; Mon, 15 Jun 2015 08:49:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4TpI-0000iJ-R7 for qemu-devel@nongnu.org; Mon, 15 Jun 2015 08:49:20 -0400 Message-ID: <557EC9CA.1030903@redhat.com> Date: Mon, 15 Jun 2015 06:49:14 -0600 From: Eric Blake MIME-Version: 1.0 References: <1434205258-1932-1-git-send-email-armbru@redhat.com> <1434205258-1932-4-git-send-email-armbru@redhat.com> In-Reply-To: <1434205258-1932-4-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E8mFquSXSJGo2LrFMMmRMWi0cLPSJo1I7" Subject: Re: [Qemu-devel] [PATCH 03/11] vl: Use error_report() for --display errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --E8mFquSXSJGo2LrFMMmRMWi0cLPSJo1I7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/13/2015 08:20 AM, Markus Armbruster wrote: > Results in nicer error messages. Before this patch: >=20 > Invalid GTK option string: gtk,lirum-larum >=20 > After: >=20 > qemu-system-x86_64: -display gtk,lirum-larum: Invalid GTK option st= ring >=20 > Of course, the thing ought to use QemuOpts instead of parsing by hand. >=20 > Signed-off-by: Markus Armbruster > --- > vl.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --E8mFquSXSJGo2LrFMMmRMWi0cLPSJo1I7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVfsnKAAoJEKeha0olJ0NqPkoH/0fTDSGz3ERFeoBTlErhT/8M jKGTWeixsixW0KIR0cJCCAT69otCbewIV6uIxKHrD5BCs6ksVrSWbipMWhUCahYV rbf6VsCOnrk9Bpt6eRSOgKdscekUHELjsJehRw1nMN3ZS3pQ2vHv0+TsG9rq7kZX UgudWKbiFd9YoeQuVeWy4LzeCH1JN/nt/qSxkTuBCaJ4nrAZowhoPLQb6rz2z7l+ xuNiDN90SKpAZAFk4ydyk6xYzP4KRPva5H+Pimf5CcS+hBfIQ3SLePNrjx4ZrMDS sGggkiDZOUz9tNDkBmsb8dKyhXeZLVPPXhu4teNizzIbRZd+vjyuIYg2S0kuwPE= =EZWP -----END PGP SIGNATURE----- --E8mFquSXSJGo2LrFMMmRMWi0cLPSJo1I7--