From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4b8F-00044V-71 for qemu-devel@nongnu.org; Mon, 15 Jun 2015 16:37:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4b8A-0000HU-Du for qemu-devel@nongnu.org; Mon, 15 Jun 2015 16:37:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56509) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4b8A-0000H8-81 for qemu-devel@nongnu.org; Mon, 15 Jun 2015 16:37:18 -0400 Message-ID: <557F377B.1070005@redhat.com> Date: Mon, 15 Jun 2015 14:37:15 -0600 From: Eric Blake MIME-Version: 1.0 References: <1434205258-1932-1-git-send-email-armbru@redhat.com> <1434205258-1932-7-git-send-email-armbru@redhat.com> In-Reply-To: <1434205258-1932-7-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="b1JjXOWamhPVvG3iWJmlc9JA4igKwsmVw" Subject: Re: [Qemu-devel] [PATCH 06/11] tpm: Avoid qerror_report() outside QMP command handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --b1JjXOWamhPVvG3iWJmlc9JA4igKwsmVw Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/13/2015 08:20 AM, Markus Armbruster wrote: > qerror_report() is a transitional interface to help with converting > existing monitor commands to QMP. It should not be used elsewhere. > Replace by error_report(). >=20 > Signed-off-by: Markus Armbruster > --- > tpm.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) >=20 > diff --git a/tpm.c b/tpm.c > index 99a9895..224e65e 100644 > --- a/tpm.c > +++ b/tpm.c > @@ -140,23 +140,21 @@ static int configure_tpm(QemuOpts *opts) > =20 > id =3D qemu_opts_id(opts); > if (id =3D=3D NULL) { > - qerror_report(ERROR_CLASS_GENERIC_ERROR, QERR_MISSING_PARAMETE= R, "id"); > + error_report(QERR_MISSING_PARAMETER, "id"); Ah, this fixes a hunk difference I pointed out in 5/11. If you need to rebase, I'd consider rearranging to put this patch first, so that the mechanical 5/11 is even more mechanical (limited to just error_setg conversion). But that's not enough reason in itself for a respin, so: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --b1JjXOWamhPVvG3iWJmlc9JA4igKwsmVw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVfzd8AAoJEKeha0olJ0Nq0gQH/1MDEh3Hum5eA4gi2FafzO4f khsgnMdleKYOaUpBwJNVAY52phy5NTSG13X/kqRMFAsnpSmR8G3eRTKPpEK7UKq9 zdj2pSTQvuhJRiMnn56Dy0Fa+oZdWJ3a3mn11zaQjr7ZO8WNEQLy8eveE5lYCKrV TGgvpXjRcCzM5hzUJbLZTZmggZsZNeFgKbFkOR16qD1Kg8YHz9SxePScwfJcxtpA CpBTZaq7pRj1cWC+pwtBEUkA7yzAPlmF8M4f7xme1tvK9ldkCyhItYUVVPOTRQ7o AH3NNfXpCHKHHtwx00hqi1d+Z2WfJcBYOXK8twbowJYGiWlXUahvtgfijicVKm8= =CTMI -----END PGP SIGNATURE----- --b1JjXOWamhPVvG3iWJmlc9JA4igKwsmVw--