From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08AE1C43381 for ; Tue, 26 Mar 2019 15:39:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C403F20863 for ; Tue, 26 Mar 2019 15:39:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731654AbfCZPj2 (ORCPT ); Tue, 26 Mar 2019 11:39:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47164 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726175AbfCZPj2 (ORCPT ); Tue, 26 Mar 2019 11:39:28 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1E9B3C057F5D; Tue, 26 Mar 2019 15:39:28 +0000 (UTC) Received: from [10.3.116.169] (ovpn-116-169.phx2.redhat.com [10.3.116.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5F1455D73F; Tue, 26 Mar 2019 15:39:24 +0000 (UTC) Subject: Re: [PATCH net 1/2] thunderx: enable page recycling for non-XDP case To: Jesper Dangaard Brouer Cc: Robert Richter , Sunil Goutham , David Miller , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vadim Lomovtsev References: <155360907744.12643.15472521931039184559.email-sent-by-dnelson@cyan> <155360908585.12643.12967701630346715912.email-sent-by-dnelson@cyan> <20190326153916.530d472e@carbon> <3ea9678c-863b-edcb-c812-1f3e7d492155@redhat.com> <20190326155902.0c0ce9fd@carbon> From: Dean Nelson Message-ID: <557efa21-d1af-8faa-3386-556359c2814b@redhat.com> Date: Tue, 26 Mar 2019 10:39:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190326155902.0c0ce9fd@carbon> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 26 Mar 2019 15:39:28 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/26/19 9:59 AM, Jesper Dangaard Brouer wrote: > On Tue, 26 Mar 2019 09:44:19 -0500 > Dean Nelson wrote: > >> On 3/26/19 9:39 AM, Jesper Dangaard Brouer wrote: >>> On Tue, 26 Mar 2019 10:04:47 -0400 >>> Dean Nelson wrote: >>> >>>> Commit 773225388dae15e72790 added code to nicvf_alloc_page() that inadvertently >>>> disables receive buffer page recycling for the non-XDP case by always NULL'ng >>>> the page pointer. >>>> >>>> This patch corrects two if-conditionals to allow for the recycling of non-XDP >>>> mode pages by only setting the page pointer to NULL when the page is not ready >>>> for recycling. >>>> >>>> Signed-off-by: Dean Nelson >>> >>> You need to add a "fixes" line like this: >>> >>> Fixes: 773225388dae ("net: thunderx: Optimize page recycling for XDP") >>> >>> And in-general reference a commit in the same way in the description. >> >> Sorry, for some reason I thought the 'Fixes' line was optional. >> >> Thank you for setting me straight. Should I repost the patchset? > > I would say, yes please. (Given the amount of patches DaveM have to > process, lets make it easy for him). Would be glad to, as I definitely agree. Thanks for responding to my question. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A18FC43381 for ; Tue, 26 Mar 2019 15:39:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18F5920823 for ; Tue, 26 Mar 2019 15:39:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pdW2UoNs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18F5920823 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hyeyxzUGuq49LSxY62GzciKAzR44VP79WON79Yjsp4c=; b=pdW2UoNsHD/kb8StWaxAK8cTx yGqdVAc9C1hJBUg6PnIw53Lmqk5VaZGoxQBEk4oCSKot4FjMDsOQwGiUrKIdvnswBULc+OeUg9DjH PPrnFcUnxurfRtICLzB0RujC4CXPzRYP3rr713cLoF14w7D3nm36LES9CJc+9Mx5umHHXn+aTHP6N xabu0UTym/NMBEw4WOxFrsmLVfmM5RFNQFzaYhXBEv7/aC0yLBAvF+0EwmKOQV6tn92yruFHS9Jb8 tzvNKc730IBMmKYsoYhtkfaukE1fHCGPSsTCRetHQOE0Oyrs7c8aLu7MNlIa9ejyrzPnuWAfGVR1Q 2qmrfcjbw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8oAn-00028j-4L; Tue, 26 Mar 2019 15:39:33 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8oAj-00028I-9O for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2019 15:39:30 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1E9B3C057F5D; Tue, 26 Mar 2019 15:39:28 +0000 (UTC) Received: from [10.3.116.169] (ovpn-116-169.phx2.redhat.com [10.3.116.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5F1455D73F; Tue, 26 Mar 2019 15:39:24 +0000 (UTC) Subject: Re: [PATCH net 1/2] thunderx: enable page recycling for non-XDP case To: Jesper Dangaard Brouer References: <155360907744.12643.15472521931039184559.email-sent-by-dnelson@cyan> <155360908585.12643.12967701630346715912.email-sent-by-dnelson@cyan> <20190326153916.530d472e@carbon> <3ea9678c-863b-edcb-c812-1f3e7d492155@redhat.com> <20190326155902.0c0ce9fd@carbon> From: Dean Nelson Message-ID: <557efa21-d1af-8faa-3386-556359c2814b@redhat.com> Date: Tue, 26 Mar 2019 10:39:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190326155902.0c0ce9fd@carbon> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 26 Mar 2019 15:39:28 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_083929_349301_BB2482B6 X-CRM114-Status: GOOD ( 16.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sunil Goutham , Robert Richter , netdev@vger.kernel.org, Vadim Lomovtsev , David Miller , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/26/19 9:59 AM, Jesper Dangaard Brouer wrote: > On Tue, 26 Mar 2019 09:44:19 -0500 > Dean Nelson wrote: > >> On 3/26/19 9:39 AM, Jesper Dangaard Brouer wrote: >>> On Tue, 26 Mar 2019 10:04:47 -0400 >>> Dean Nelson wrote: >>> >>>> Commit 773225388dae15e72790 added code to nicvf_alloc_page() that inadvertently >>>> disables receive buffer page recycling for the non-XDP case by always NULL'ng >>>> the page pointer. >>>> >>>> This patch corrects two if-conditionals to allow for the recycling of non-XDP >>>> mode pages by only setting the page pointer to NULL when the page is not ready >>>> for recycling. >>>> >>>> Signed-off-by: Dean Nelson >>> >>> You need to add a "fixes" line like this: >>> >>> Fixes: 773225388dae ("net: thunderx: Optimize page recycling for XDP") >>> >>> And in-general reference a commit in the same way in the description. >> >> Sorry, for some reason I thought the 'Fixes' line was optional. >> >> Thank you for setting me straight. Should I repost the patchset? > > I would say, yes please. (Given the amount of patches DaveM have to > process, lets make it easy for him). Would be glad to, as I definitely agree. Thanks for responding to my question. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel