From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagar Dharia Subject: Re: [PATCH 1/3] SLIMbus: Device management on SLIMbus Date: Tue, 16 Jun 2015 09:22:31 -0600 Message-ID: <55803F37.9050809@codeaurora.org> References: <1434260958-13732-1-git-send-email-sdharia@codeaurora.org> <1434260958-13732-2-git-send-email-sdharia@codeaurora.org> <20150615105424.GJ18309@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:59451 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754654AbbFPPWg (ORCPT ); Tue, 16 Jun 2015 11:22:36 -0400 In-Reply-To: <20150615105424.GJ18309@sirena.org.uk> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Mark Brown Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, bp@suse.de, poeschel@lemonage.de, treding@nvidia.com, gong.chen@linux.intel.com, andreas.noever@gmail.com, alan@linux.intel.com, mathieu.poirier@linaro.org, daniel@ffwll.ch, oded.gabbay@amd.com, jkosina@suse.cz, sharon.dvir1@mail.huji.ac.il, joe@perches.com, davem@davemloft.net, james.hogan@imgtec.com, michael.opdenacker@free-electrons.com, daniel.thompson@linaro.org, nkaje@codeaurora.org, kheitke@audience.com, mlocke@codeaurora.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org On 6/15/2015 4:54 AM, Mark Brown wrote: > On Sat, Jun 13, 2015 at 11:49:16PM -0600, Sagar Dharia wrote: Thanks for the comments. I will take care of most of the comments from you, and Joe and upload V2 shortly. I will also include a controller driver this time. > >> +void slim_ctrl_add_boarddevs(struct slim_controller *ctrl) >> +{ > Why are these operations split? Some slaves may choose to do expensive operations in their probes (or wait for logical address assignment). That will delay/block controller registration and further HW initialization of the controller. I did not see any downside/side-effect in splitting them. I am open however to have them combined if that's the preferred way. Thanks Sagar -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation