From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36688)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1Z5Fbk-0000K5-Bq
	for qemu-devel@nongnu.org; Wed, 17 Jun 2015 11:50:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1Z5Fbg-0006WW-BZ
	for qemu-devel@nongnu.org; Wed, 17 Jun 2015 11:50:32 -0400
Received: from mailapp01.imgtec.com ([195.59.15.196]:2188)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1Z5Fbg-0006Va-5C
	for qemu-devel@nongnu.org; Wed, 17 Jun 2015 11:50:28 -0400
Message-ID: <55819737.1040106@imgtec.com>
Date: Wed, 17 Jun 2015 16:50:15 +0100
From: Leon Alrae <leon.alrae@imgtec.com>
MIME-Version: 1.0
References: <1434117743-53520-1-git-send-email-yongbok.kim@imgtec.com>
	<1434117743-53520-10-git-send-email-yongbok.kim@imgtec.com>
In-Reply-To: <1434117743-53520-10-git-send-email-yongbok.kim@imgtec.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 09/13] target-mips: microMIPS32 R6 POOL32F
	instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yongbok Kim <yongbok.kim@imgtec.com>, qemu-devel@nongnu.org
Cc: aurelien@aurel32.net

On 12/06/2015 15:02, Yongbok Kim wrote:
> @@ -14155,13 +14243,88 @@ static void decode_micromips32_opc (CPUMIPSState *env, DisasContext *ctx,
>                  break;
>              case 0x38:
>                  /* cmovs */
> -                switch ((ctx->opcode >> 6) & 0x3) {
> +                switch ((ctx->opcode >> 6) & 0x7) {
>                  case MOVN_FMT:
> +                    /* SELNEZ_FMT */
> +                    if (ctx->insn_flags & ISA_MIPS32R6) {
> +                        switch (ctx->opcode >> 9 & 0x3) {

Could you please add parentheses for consistency? (also in other patches in
this series)

Otherwise,

Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>