From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from down.free-electrons.com ([37.187.137.238]:47966 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756090AbbFRStf (ORCPT ); Thu, 18 Jun 2015 14:49:35 -0400 Message-ID: <558312B7.6010708@free-electrons.com> Date: Thu, 18 Jun 2015 20:49:27 +0200 From: Gregory CLEMENT MIME-Version: 1.0 To: Michael Turquette , Stephen Boyd CC: Thomas Petazzoni , Boris Brezillon , Jason Cooper , Tawfik Bayouk , Andrew Lunn , Kevin Hilman , stable@vger.kernel.org, Eran Ben-Avi , Nadav Haklai , Lior Amsalem , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Subject: Re: [PATCH v2] clk: mvebu: flag the crypto clk as CLK_IGNORE_UNUSED References: <1434470179-20835-1-git-send-email-boris.brezillon@free-electrons.com> <55816094.2020208@free-electrons.com> <20150618183654.25948.26168@quantum> In-Reply-To: <20150618183654.25948.26168@quantum> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: Hi Mike, On 18/06/2015 20:36, Michael Turquette wrote: > Quoting Gregory CLEMENT (2015-06-17 04:57:08) >> Hi Mike, Stephen, >> >> On 16/06/2015 17:56, Boris Brezillon wrote: >>> The crypto SRAM, used by the armada 370 cpuidle code to workaround a bug >>> in the BootROM code, requires the crypto clk to be up and running. >>> Flag the crypto clk as IGNORE_UNUSED until we add the proper >>> infrastructure to define the crypto SRAM in the DT and reference the crypto >>> clk in this SRAM node. >>> >>> Reported-by: Kevin Hilman >>> Signed-off-by: Boris Brezillon >>> Tested-by: Kevin Hilman >>> Fixes: 29e623475c50267ee3aaa49ebb6cbe107bce8d2a ("clk: mvebu: add >>> missing CESA gate clk"). >>> Cc: #4.1 >> >> Acked-by: Gregory CLEMENT >> >> Would it possible to apply this fix on 4.1-rc8 ? > > Hi Gregory, > > I'm a bit confused by this. This patch fixes "clk: mvebu: add missing > CESA gate clk", right? That patch lives in clk-next. It was not pushed > to Linus' tree yet via a -fixes branch. > > Thus I can just apply this patch to clk-next and the problem should be > resolved in clk-next, no? You're right I was confused by the " #4.1" tag, and I thought it was already part of 4.1. So indeed you just have to apply it in clk-next. You can remove the Fixes: and CC: line. And even better you can squashed it into 4d52b2acefdf "clk: mvebu: add missing CESA gate clk", if your clk-next branch is not immutable. > > Furthermore, I do not have 29e623475c50267ee3aaa49ebb6cbe107bce8d2a > anywhere in my tree. I'm not sure where this sha1 hash came from. Me neither :) Thanks, Gregory >> >>> --- >>> Changes since v1: >>> - add the Reported-by tag >>> - add the missing trailing ',' >>> >>> drivers/clk/mvebu/armada-370.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/clk/mvebu/armada-370.c b/drivers/clk/mvebu/armada-370.c >>> index c19fd77..2c7c108 100644 >>> --- a/drivers/clk/mvebu/armada-370.c >>> +++ b/drivers/clk/mvebu/armada-370.c >>> @@ -163,7 +163,7 @@ static const struct clk_gating_soc_desc a370_gating_desc[] __initconst = { >>> { "pex1", "pex1_en", 9, 0 }, >>> { "sata0", NULL, 15, 0 }, >>> { "sdio", NULL, 17, 0 }, >>> - { "crypto", NULL, 23, 0 }, >>> + { "crypto", NULL, 23, CLK_IGNORE_UNUSED }, >>> { "tdm", NULL, 25, 0 }, >>> { "ddr", NULL, 28, CLK_IGNORE_UNUSED }, >>> { "sata1", NULL, 30, 0 }, >>> >> >> >> -- >> Gregory Clement, Free Electrons >> Kernel, drivers, real-time and embedded Linux >> development, consulting, training and support. >> http://free-electrons.com >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Thu, 18 Jun 2015 20:49:27 +0200 Subject: [PATCH v2] clk: mvebu: flag the crypto clk as CLK_IGNORE_UNUSED In-Reply-To: <20150618183654.25948.26168@quantum> References: <1434470179-20835-1-git-send-email-boris.brezillon@free-electrons.com> <55816094.2020208@free-electrons.com> <20150618183654.25948.26168@quantum> Message-ID: <558312B7.6010708@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mike, On 18/06/2015 20:36, Michael Turquette wrote: > Quoting Gregory CLEMENT (2015-06-17 04:57:08) >> Hi Mike, Stephen, >> >> On 16/06/2015 17:56, Boris Brezillon wrote: >>> The crypto SRAM, used by the armada 370 cpuidle code to workaround a bug >>> in the BootROM code, requires the crypto clk to be up and running. >>> Flag the crypto clk as IGNORE_UNUSED until we add the proper >>> infrastructure to define the crypto SRAM in the DT and reference the crypto >>> clk in this SRAM node. >>> >>> Reported-by: Kevin Hilman >>> Signed-off-by: Boris Brezillon >>> Tested-by: Kevin Hilman >>> Fixes: 29e623475c50267ee3aaa49ebb6cbe107bce8d2a ("clk: mvebu: add >>> missing CESA gate clk"). >>> Cc: #4.1 >> >> Acked-by: Gregory CLEMENT >> >> Would it possible to apply this fix on 4.1-rc8 ? > > Hi Gregory, > > I'm a bit confused by this. This patch fixes "clk: mvebu: add missing > CESA gate clk", right? That patch lives in clk-next. It was not pushed > to Linus' tree yet via a -fixes branch. > > Thus I can just apply this patch to clk-next and the problem should be > resolved in clk-next, no? You're right I was confused by the " #4.1" tag, and I thought it was already part of 4.1. So indeed you just have to apply it in clk-next. You can remove the Fixes: and CC: line. And even better you can squashed it into 4d52b2acefdf "clk: mvebu: add missing CESA gate clk", if your clk-next branch is not immutable. > > Furthermore, I do not have 29e623475c50267ee3aaa49ebb6cbe107bce8d2a > anywhere in my tree. I'm not sure where this sha1 hash came from. Me neither :) Thanks, Gregory >> >>> --- >>> Changes since v1: >>> - add the Reported-by tag >>> - add the missing trailing ',' >>> >>> drivers/clk/mvebu/armada-370.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/clk/mvebu/armada-370.c b/drivers/clk/mvebu/armada-370.c >>> index c19fd77..2c7c108 100644 >>> --- a/drivers/clk/mvebu/armada-370.c >>> +++ b/drivers/clk/mvebu/armada-370.c >>> @@ -163,7 +163,7 @@ static const struct clk_gating_soc_desc a370_gating_desc[] __initconst = { >>> { "pex1", "pex1_en", 9, 0 }, >>> { "sata0", NULL, 15, 0 }, >>> { "sdio", NULL, 17, 0 }, >>> - { "crypto", NULL, 23, 0 }, >>> + { "crypto", NULL, 23, CLK_IGNORE_UNUSED }, >>> { "tdm", NULL, 25, 0 }, >>> { "ddr", NULL, 28, CLK_IGNORE_UNUSED }, >>> { "sata1", NULL, 30, 0 }, >>> >> >> >> -- >> Gregory Clement, Free Electrons >> Kernel, drivers, real-time and embedded Linux >> development, consulting, training and support. >> http://free-electrons.com >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel at lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com