From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755422AbbFSSz2 (ORCPT ); Fri, 19 Jun 2015 14:55:28 -0400 Received: from mail-yh0-f52.google.com ([209.85.213.52]:33613 "EHLO mail-yh0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752241AbbFSSyq (ORCPT ); Fri, 19 Jun 2015 14:54:46 -0400 Message-ID: <5584654B.6050500@gmail.com> Date: Fri, 19 Jun 2015 14:54:03 -0400 From: Austin S Hemmelgarn User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Ilia Mirkin , Dave Hansen CC: dave.hansen@linux.intel.com, john@johnmccutchan.com, rlove@rlove.org, eparis@parisplace.org, viro@zeniv.linux.org.uk, Linus Torvalds , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] fs: inotify: systemd needs it so make it depend on CONFIG_EMBEDDED References: <20150619180742.62D31523@viggo.jf.intel.com> In-Reply-To: x-hashcash: 1:21:150619:imirkin@alum.mit.edu::20b48cb1b5cd0e75ea5aa1087c820cfb:482da30c15a17def x-hashcash: 1:21:150619:dave@sr71.net::a14579da8f354e2d1a79599f70924209:835a74faf480a6df x-hashcash: 1:21:150619:dave.hansen@linux.intel.com::8a66c1c2e23b99461452096933e9a097:474bd68576c1037f x-hashcash: 1:21:150619:john@johnmccutchan.com::92a5991dcd562555356e964768689c0a:b17414f1b33a0bab x-hashcash: 1:21:150619:rlove@rlove.org::68d4aaf29ea8a1acfd34a961fd81be2b:13280f04912b7c14 x-hashcash: 1:21:150619:eparis@parisplace.org::8abce2d3d07c1e9638133552d323e03a:ecd6de6c86403ceb x-hashcash: 1:21:150619:viro@zeniv.linux.org.uk::48e6abae6e7fc9ca436dde8bee1f20cb:19e4fa8472efd5a1 x-hashcash: 1:21:150619:torvalds@linux-foundation.org::672a07aa4f702bafefe75464f41cbc9:2ed0baa083f44a85 x-hashcash: 1:21:150619:linux-kernel@vger.kernel.org::1c5b58b5355bf450a67bc00e52a1dfbc:1cb4b230676e06d7 x-stampprotocols: hashcash:1:17;mbound:0:10:3000:5000 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha1; boundary="------------ms030208000402040306040502" X-Antivirus: avast! (VPS 150619-1, 2015-06-19), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a cryptographically signed message in MIME format. --------------ms030208000402040306040502 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 2015-06-19 14:18, Ilia Mirkin wrote: > On Fri, Jun 19, 2015 at 2:07 PM, Dave Hansen wrote: >> >> From: Dave Hansen >> >> I have a little microbenchmark that sits and does write() in a loop. >> The number one kernel function in the profiles is __srcu_read_lock() >> from fsnotify(). I decided to turn off INOTIFY in order to see what >> the potential from optimizing this path would be. I ended up with >> a system at the rescue console as systemd complained that dependencies= >> were not met mounting some non-root filesystems: >> >> systemd: inotify_init1() failed: Function not implemented >> systemd: Dependency failed for Mark the need to relabel after= reboot. >> systemd: Triggering OnFailure=3D dependencies of local-fs.tar= get. >> systemd: inotify_init1() failed: Function not implemented >> systemd: Dependency failed for /gcc. >> >> It looks like CONFIG_INOTIFY is now a critical part of any system >> that wants to both use systemd and boot. Let's make it depend >> on CONFIG_EMBEDDED. > > Is systemd depending on something really reason enough to make it > depend on EMBEDDED? For example all the cgroups stuff is not only not > dependent on embedded, but also off by default, and I'm sure there are > a boatload of other dependencies which any normal system has no > business worrying about but that are required by systemd. > > -ilia I agree with this, kconfig isn't designed to make sure that your system=20 will boot. There are plenty of non-embedded systems that don't use=20 systemd at all (such as every Linux based system on the TOP500 list, and = a large majority of Gentoo installations), and also have no reason to=20 have INOTIFY enabled. I would stipulate however that systemd _should_ (if it doesn't already)=20 clearly document this and any other kernel configuration dependencies. --------------ms030208000402040306040502 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGuDCC BrQwggScoAMCAQICAxBuVTANBgkqhkiG9w0BAQ0FADB5MRAwDgYDVQQKEwdSb290IENBMR4w HAYDVQQLExVodHRwOi8vd3d3LmNhY2VydC5vcmcxIjAgBgNVBAMTGUNBIENlcnQgU2lnbmlu ZyBBdXRob3JpdHkxITAfBgkqhkiG9w0BCQEWEnN1cHBvcnRAY2FjZXJ0Lm9yZzAeFw0xNTAz MjUxOTM0MzhaFw0xNTA5MjExOTM0MzhaMGMxGDAWBgNVBAMTD0NBY2VydCBXb1QgVXNlcjEj MCEGCSqGSIb3DQEJARYUYWhmZXJyb2luN0BnbWFpbC5jb20xIjAgBgkqhkiG9w0BCQEWE2Fo ZW1tZWxnQG9oaW9ndC5jb20wggIiMA0GCSqGSIb3DQEBAQUAA4ICDwAwggIKAoICAQCdD/zW 2rRAFCLnDfXpWxU1+ODqRVUgzHvrRO7ADUxRo1CBDc3JSX5TIW2OGmQ3DAKGOACp8Z0sgxMc B05tzAZ/M7m4jajVrwwdVCdrwVGxTdAai7Kwg4ZCVfyMVhcwo8R2eW3QahBx34G0RKumK9sZ ZQSQ+zULAzpY6uz7T1sAk/erMoivRXF6u8WvOsLkOD1F/Xyv1ZccSUG5YeDgZgc0nZUBvyIp zXSHjgWerFkrxEM3y2z/Ff3eL1sgGYecV/I1F+I5S01V7Kclt/qRW10c/4JEGRcI1FmrJBPu BtMYPbg/3Y9LZROYN+mVIFxZxOfrmjfFZ96xt/TaMXo8vcEKtWcNEjhGBjEbfMUEm4aq8ygQ 4MuEcpJc8DJCHBkg2KBk13DkbU2qNepTD6Uip1C+g+KMr0nd6KOJqSH27ZuNY4xqV4hIxFHp ex0zY7mq6fV2o6sKBGQzRdI20FDYmNjsLJwjH6qJ8laxFphZnPRpBThmu0AjuBWE72GnI1oA aO+bs92MQGJernt7hByCnDO82W/ykbVz+Ge3Sax8NY0m2Xdvp6WFDY/PjD9CdaJ9nwQGsUSa N54lrZ2qMTeCI9Vauwf6U69BA42xgk65VvxvTNqji+tZ4aZbarZ7el2/QDHOb/rRwlCFplS/ z4l1f1nOrE6bnDl5RBJyW3zi74P6GwIDAQABo4IBWTCCAVUwDAYDVR0TAQH/BAIwADBWBglg hkgBhvhCAQ0ESRZHVG8gZ2V0IHlvdXIgb3duIGNlcnRpZmljYXRlIGZvciBGUkVFIGhlYWQg b3ZlciB0byBodHRwOi8vd3d3LkNBY2VydC5vcmcwDgYDVR0PAQH/BAQDAgOoMEAGA1UdJQQ5 MDcGCCsGAQUFBwMEBggrBgEFBQcDAgYKKwYBBAGCNwoDBAYKKwYBBAGCNwoDAwYJYIZIAYb4 QgQBMDIGCCsGAQUFBwEBBCYwJDAiBggrBgEFBQcwAYYWaHR0cDovL29jc3AuY2FjZXJ0Lm9y ZzAxBgNVHR8EKjAoMCagJKAihiBodHRwOi8vY3JsLmNhY2VydC5vcmcvcmV2b2tlLmNybDA0 BgNVHREELTArgRRhaGZlcnJvaW43QGdtYWlsLmNvbYETYWhlbW1lbGdAb2hpb2d0LmNvbTAN BgkqhkiG9w0BAQ0FAAOCAgEAGvl7xb42JMRH5D/vCIDYvFY3dR2FPd5kmOqpKU/fvQ8ovmJa p5N/FDrsCL+YdslxPY+AAn78PYmL5pFHTdRadT++07DPIMtQyy2qd+XRmz6zP8Il7vGcEDmO WmMLYMq4xV9s/N7t7JJp6ftdIYUcoTVChUgilDaRWMLidtslCdRsBVfUjPb1bF5Ua31diKDP e0M9/e2CU36rbcTtiNCXhptMigzuL3zJXUf2B9jyUV8pnqNEQH36fqJ7YTBLcpq3aYa2XbAH Hgx9GehJBIqwspDmhPCFZ/QmqUXCkt+XfvinQ2NzKR6P3+OdYbwqzVX8BdMeojh7Ig8x/nIx mQ+/ufstL1ZYp0bg13fyK/hPYSIBpayaC76vzWovkIm70DIDRIFLi20p/qTd7rfDYy831Hjm +lDdCECF9bIXEWFk33kA97dgQIMbf5chEmlFg8S0e4iw7LMjvRqMX3eCD8GJ2+oqyZUwzZxy S0Mx+rBld5rrN7LsXwZ671HsGqNeYbYeU25e7t7/Gcc6Bd/kPfA+adEuUGFcvUKH3trDYqNq 6mOkAd8WO/mQadlc3ztS++XDMhmIpfBre9MPAr6usqf+wc+R8Nk9KLK39kEgrqVfzc/fgf8L MaD4rHnusdg4gca6Yi+kNrm99anw7SwaBrBvULYBp7ixNRUhaYiNW4YjTrYxggShMIIEnQIB ATCBgDB5MRAwDgYDVQQKEwdSb290IENBMR4wHAYDVQQLExVodHRwOi8vd3d3LmNhY2VydC5v cmcxIjAgBgNVBAMTGUNBIENlcnQgU2lnbmluZyBBdXRob3JpdHkxITAfBgkqhkiG9w0BCQEW EnN1cHBvcnRAY2FjZXJ0Lm9yZwIDEG5VMAkGBSsOAwIaBQCgggH1MBgGCSqGSIb3DQEJAzEL BgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTE1MDYxOTE4NTQwM1owIwYJKoZIhvcNAQkE MRYEFNHmvLM9uQZFZ8cefJX83ETUBYBGMGwGCSqGSIb3DQEJDzFfMF0wCwYJYIZIAWUDBAEq MAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwIC AUAwBwYFKw4DAgcwDQYIKoZIhvcNAwICASgwgZEGCSsGAQQBgjcQBDGBgzCBgDB5MRAwDgYD VQQKEwdSb290IENBMR4wHAYDVQQLExVodHRwOi8vd3d3LmNhY2VydC5vcmcxIjAgBgNVBAMT GUNBIENlcnQgU2lnbmluZyBBdXRob3JpdHkxITAfBgkqhkiG9w0BCQEWEnN1cHBvcnRAY2Fj ZXJ0Lm9yZwIDEG5VMIGTBgsqhkiG9w0BCRACCzGBg6CBgDB5MRAwDgYDVQQKEwdSb290IENB MR4wHAYDVQQLExVodHRwOi8vd3d3LmNhY2VydC5vcmcxIjAgBgNVBAMTGUNBIENlcnQgU2ln bmluZyBBdXRob3JpdHkxITAfBgkqhkiG9w0BCQEWEnN1cHBvcnRAY2FjZXJ0Lm9yZwIDEG5V MA0GCSqGSIb3DQEBAQUABIICAGgywCTUx9KcrWsrQp/ZHcaprm6iCrG67XD+na4aA0OTVJbp 9/OZHgyPb8Nt7+yXiSYMXz/8BuyiJs505udIqB+RSm7YNRrdpuQBWE5BMvAhZ7SvuBAdGZsj 1eW/RT+detxMAKQC5sT2HQSaqzTpxEBzM4dIUnM5yWjdnwXZ1T312fWozsgQhXeVse1m7Pe/ 0AE68xi/kENxp6amQbPHBlYfNCQ5V6fIaUpFPzRVvuID5MTR3lM6dFclP7iXMqPzzAUBTQI5 nSuvBoOVdBJk6YiOPKaAmubPbnzrnMAvycT6QCxeF43vP9KGupHg+1tWUORAZzBXm8SvERSj /sxUcz9mh9p0avt4HRL4JmMOqGqqAGtdAu5vc0oKsGtmfjtO4IRFHyjPRpBGyrAR19HYutQV egA/3IbDjXM2W290eLQuwvOkkYfqCjRgs16RZXbi0GxsGvA3NDKGdpWMFIfpZgefz9XvcDr1 SMFtXhr90NC6OBZme5kKVo0Wnu2QQEgqPtZ4ppHOsHeyBbRNKs0il7k9c4Q67eAs96FOEjqh MZ+tliX85jg+X13aeThRL8N7WQ19V2gAHM5W549V5TlJwXwBCSDFHaRDJRKGcgZZy6kXZJVv MkcvIfwy0OOKQtzmpBx+pApYUQ3p1VQOCaBAWe3mdOgk0M+8a7fX5OOGW/XwAAAAAAAA --------------ms030208000402040306040502-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/