From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z68DD-0007GF-Hk for qemu-devel@nongnu.org; Fri, 19 Jun 2015 22:08:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z68DC-00041p-LC for qemu-devel@nongnu.org; Fri, 19 Jun 2015 22:08:51 -0400 Message-ID: <5584CB2C.6030202@redhat.com> Date: Fri, 19 Jun 2015 22:08:44 -0400 From: John Snow MIME-Version: 1.0 References: <1434765047-29333-1-git-send-email-jsnow@redhat.com> <1434765047-29333-17-git-send-email-jsnow@redhat.com> In-Reply-To: <1434765047-29333-17-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 16/16] qtest/ahci: ncq migration test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On 06/19/2015 09:50 PM, John Snow wrote: > Signed-off-by: John Snow > --- > tests/ahci-test.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/tests/ahci-test.c b/tests/ahci-test.c > index 941e0dd..206e6bb 100644 > --- a/tests/ahci-test.c > +++ b/tests/ahci-test.c > @@ -1140,9 +1140,9 @@ static void test_migrate_sanity(void) > } > > /** > - * DMA Migration test: Write a pattern, migrate, then read. > + * Simple migration test: Write a pattern, migrate, then read. > */ > -static void test_migrate_dma(void) > +static void ahci_migrate_simple(uint8_t cmd_read, uint8_t cmd_write) > { > AHCIQState *src, *dst; > uint8_t px; > @@ -1183,6 +1183,16 @@ static void test_migrate_dma(void) > g_free(tx); > } > This is what I get for staying up so late... It would help if I actually used the parameters I created to use the right command. Fixed offline in a v2, will send out after other comments if any. > +static void test_migrate_dma(void) > +{ > + ahci_migrate_simple(CMD_READ_DMA, CMD_WRITE_DMA); > +} > + > +static void test_migrate_ncq(void) > +{ > + ahci_migrate_simple(READ_FPDMA_QUEUED, WRITE_FPDMA_QUEUED); > +} > + > /** > * DMA Error Test > * > @@ -1665,6 +1675,7 @@ int main(int argc, char **argv) > qtest_add_func("/ahci/reset", test_reset); > > qtest_add_func("/ahci/io/ncq/simple", test_ncq_simple); > + qtest_add_func("/ahci/migrate/ncq/simple", test_migrate_ncq); > > ret = g_test_run(); > >