From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AA6E23D9 for ; Sat, 30 Jul 2022 09:13:09 +0000 (UTC) Received: by mail-ej1-f45.google.com with SMTP id l23so12162681ejr.5 for ; Sat, 30 Jul 2022 02:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F8fhUxE3x4wOe3m4a14najZDDA734PpdZ0zvY9IBgdA=; b=ZG2IrV2r1EWLt75BM97iRoI2Fc0pagt70o4R2poxmBf1kaPFF05otKfuGf7gXtlNu+ /dCPH7viH0STK8OcySYRw+QBBy73BSHjr+CT0al1b+vpb2imlIe74RmeRrf9pQqUJaH5 TmBS8LD7rue5YdqAeAFvd+htM27uzgkRJKkN/kfIiTlXZVxmf1bjlsTP2BM0P0T1kNv7 XoxF9QpD+8/TlHICB89Z2XN/1dNWdNao5r8EoIVdL+YOvRB+TDYnU99NpmticLyjn5B1 8h1LYPxQE/lZczOWieZs/hZZCk2VgzErcnMC5xg6qLsBux25HfhSNtlgrJRdhFhQT/L2 aydg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F8fhUxE3x4wOe3m4a14najZDDA734PpdZ0zvY9IBgdA=; b=NsiAtL1buXwbu7eJSD7UN0kJWJCd6NUPVF4hfWJ9ulBiNOE1wYsG2l6B5lT2oht6GL pw3nd5TMEgugqwS7iQUN55djcsWV/LTt8fXDQx3/1PWTAgE1mmCpcDIbJagfKA8v+IrV mVtjQTujLvNrdFXTU7IAbCS/dHP5c64l6adr+ebgKnTyAiZl4qWmevZbh4bOeFJvPgM/ CwSqPuAYunzLtUSCgqfD75VvEVAhSWbxjrPPcyCok39F4YzYSx368K2WnjvBuRiXuM5t lX90HMu8kaMZUopvvWTyvO/e4ALoW5jNtrsRo5C73g/Ntg1epeV5ktcHs6V/b2nvr3pf NkgQ== X-Gm-Message-State: AJIora82inZ+4mxC4du9wFwNyEx+YpTqfdHBxe8uNlA6o2J8sDGY5oHL vYrMjEifmdf92ZRoTfS9fCI= X-Google-Smtp-Source: AGRyM1vnGZx3SWdOvFK05YcUTuAQpbJMQBq6meu894/eIUroxXOHiUFMsPL5aHg++vyEFuUAzaEVrw== X-Received: by 2002:a17:907:948e:b0:72d:3fd2:5da0 with SMTP id dm14-20020a170907948e00b0072d3fd25da0mr5613928ejc.225.1659172387794; Sat, 30 Jul 2022 02:13:07 -0700 (PDT) Received: from jernej-laptop.localnet (194-152-27-124.dynamic.telemach.net. [194.152.27.124]) by smtp.gmail.com with ESMTPSA id j10-20020a17090623ea00b0072b616ade26sm1344215ejg.216.2022.07.30.02.13.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Jul 2022 02:13:07 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Martin Blumenstingl , Chen-Yu Tsai , Philipp Zabel , Jerome Brunet , Samuel Holland , Thomas Zimmermann , Daniel Vetter , Emma Anholt , David Airlie , Maarten Lankhorst , Noralf =?ISO-8859-1?Q?Tr=F8nnes?= , Kevin Hilman , Neil Armstrong , Maxime Ripard , Maxime Ripard Cc: Maxime Ripard , linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Phil Elwell , Mateusz Kwiatkowski , linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven , Dave Stevenson , linux-amlogic@lists.infradead.org, dri-devel@lists.freedesktop.org, Dom Cobley Subject: Re: [PATCH v1 25/35] drm/sun4i: tv: Remove unused mode_valid Date: Sat, 30 Jul 2022 11:13:05 +0200 Message-ID: <5587265.DvuYhMxLoT@jernej-laptop> In-Reply-To: <20220728-rpi-analog-tv-properties-v1-25-3d53ae722097@cerno.tech> References: <20220728-rpi-analog-tv-properties-v1-0-3d53ae722097@cerno.tech> <20220728-rpi-analog-tv-properties-v1-25-3d53ae722097@cerno.tech> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Dne petek, 29. julij 2022 ob 18:35:08 CEST je Maxime Ripard napisal(a): > The mode_valid implementation is pretty much a nop, let's remove it. > > Signed-off-by: Maxime Ripard Reviewed-by: Jernej Skrabec Best regards, Jernej > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c > b/drivers/gpu/drm/sun4i/sun4i_tv.c index 94883abe0dfd..53152d77c392 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_tv.c > +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c > @@ -497,16 +497,8 @@ static int sun4i_tv_comp_get_modes(struct drm_connector > *connector) return i; > } > > -static int sun4i_tv_comp_mode_valid(struct drm_connector *connector, > - struct drm_display_mode *mode) > -{ > - /* TODO */ > - return MODE_OK; > -} > - > static const struct drm_connector_helper_funcs > sun4i_tv_comp_connector_helper_funcs = { .get_modes = > sun4i_tv_comp_get_modes, > - .mode_valid = sun4i_tv_comp_mode_valid, > }; > > static void From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AB93C04A68 for ; Sat, 30 Jul 2022 09:13:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A28710EB61; Sat, 30 Jul 2022 09:13:10 +0000 (UTC) Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D4C710EB61 for ; Sat, 30 Jul 2022 09:13:09 +0000 (UTC) Received: by mail-ej1-x630.google.com with SMTP id bp15so12164338ejb.6 for ; Sat, 30 Jul 2022 02:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F8fhUxE3x4wOe3m4a14najZDDA734PpdZ0zvY9IBgdA=; b=ZG2IrV2r1EWLt75BM97iRoI2Fc0pagt70o4R2poxmBf1kaPFF05otKfuGf7gXtlNu+ /dCPH7viH0STK8OcySYRw+QBBy73BSHjr+CT0al1b+vpb2imlIe74RmeRrf9pQqUJaH5 TmBS8LD7rue5YdqAeAFvd+htM27uzgkRJKkN/kfIiTlXZVxmf1bjlsTP2BM0P0T1kNv7 XoxF9QpD+8/TlHICB89Z2XN/1dNWdNao5r8EoIVdL+YOvRB+TDYnU99NpmticLyjn5B1 8h1LYPxQE/lZczOWieZs/hZZCk2VgzErcnMC5xg6qLsBux25HfhSNtlgrJRdhFhQT/L2 aydg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F8fhUxE3x4wOe3m4a14najZDDA734PpdZ0zvY9IBgdA=; b=KXImAFs3WXhHjFlVEkIdJOESAHtw7iF4HNJm7KKIVWRqyiUGBkdx9ZiJlv8QNybpxt BR8f+QTpXwPrcBc6/2tcBIVQX4sRm0kW114hLEZgi7CcnuG0hQA+JlY3/3ldfl+KI2sg jr5CFo6BxTTFMPUv/kt3YHORbu4Q4mwCD5eauB3lPB7/V2DZl/x8Td0bvMwK44s4W0KA OgSpAhAz3Ux4tl1vmhTSxUFv/7/be+Z83ViyuD+DbSKv6sBdjYT5ouwsAM1CL7P9VNx5 +QR1jGUDdF76Vd/uUkWrvELo2ngUCMYq8H/nlsYfZy6jArTYF4QiafJhx4O/cMnAKwpc 8yKg== X-Gm-Message-State: AJIora/GB/oCjXYpVL1losfr906GX1bDmlS2k5SFC4NNIoxEOUUMGkSH A2D18tSqOrVgDC5MGUF/Rpg= X-Google-Smtp-Source: AGRyM1vnGZx3SWdOvFK05YcUTuAQpbJMQBq6meu894/eIUroxXOHiUFMsPL5aHg++vyEFuUAzaEVrw== X-Received: by 2002:a17:907:948e:b0:72d:3fd2:5da0 with SMTP id dm14-20020a170907948e00b0072d3fd25da0mr5613928ejc.225.1659172387794; Sat, 30 Jul 2022 02:13:07 -0700 (PDT) Received: from jernej-laptop.localnet (194-152-27-124.dynamic.telemach.net. [194.152.27.124]) by smtp.gmail.com with ESMTPSA id j10-20020a17090623ea00b0072b616ade26sm1344215ejg.216.2022.07.30.02.13.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Jul 2022 02:13:07 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Martin Blumenstingl , Chen-Yu Tsai , Philipp Zabel , Jerome Brunet , Samuel Holland , Thomas Zimmermann , Daniel Vetter , Emma Anholt , David Airlie , Maarten Lankhorst , Noralf =?ISO-8859-1?Q?Tr=F8nnes?= , Kevin Hilman , Neil Armstrong , Maxime Ripard , Maxime Ripard Subject: Re: [PATCH v1 25/35] drm/sun4i: tv: Remove unused mode_valid Date: Sat, 30 Jul 2022 11:13:05 +0200 Message-ID: <5587265.DvuYhMxLoT@jernej-laptop> In-Reply-To: <20220728-rpi-analog-tv-properties-v1-25-3d53ae722097@cerno.tech> References: <20220728-rpi-analog-tv-properties-v1-0-3d53ae722097@cerno.tech> <20220728-rpi-analog-tv-properties-v1-25-3d53ae722097@cerno.tech> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Mateusz Kwiatkowski , Geert Uytterhoeven , Maxime Ripard , linux-amlogic@lists.infradead.org, linux-sunxi@lists.linux.dev, Phil Elwell , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Dne petek, 29. julij 2022 ob 18:35:08 CEST je Maxime Ripard napisal(a): > The mode_valid implementation is pretty much a nop, let's remove it. > > Signed-off-by: Maxime Ripard Reviewed-by: Jernej Skrabec Best regards, Jernej > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c > b/drivers/gpu/drm/sun4i/sun4i_tv.c index 94883abe0dfd..53152d77c392 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_tv.c > +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c > @@ -497,16 +497,8 @@ static int sun4i_tv_comp_get_modes(struct drm_connector > *connector) return i; > } > > -static int sun4i_tv_comp_mode_valid(struct drm_connector *connector, > - struct drm_display_mode *mode) > -{ > - /* TODO */ > - return MODE_OK; > -} > - > static const struct drm_connector_helper_funcs > sun4i_tv_comp_connector_helper_funcs = { .get_modes = > sun4i_tv_comp_get_modes, > - .mode_valid = sun4i_tv_comp_mode_valid, > }; > > static void From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0394EC04A68 for ; Sat, 30 Jul 2022 09:13:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CZeLqkToKEtAlA5eIKm1hdGFoP2GvKXkNWcCQ/f7hd8=; b=qKlp8huJu7/dhM 9kWqAYyeo8c80XnuDYyPPl29dg7oPkt7i9S4iUKcEtEGHv6x0baylGdsnJ84CsWXmVGH0Fw/2HDKI 8VMWYGkoNBbhesKJzwvSMFIHzxRq1smIMbq/CyRNUg8tWECoEaTtS/gNZiKwGfkxn1ztuH6vP7bQu 8JaTVgWa1hGwK9ny8t/SXRGMOxUVMThk+LfcCdCiEw8PQ8FlsgIjMaArbboD0Sv5v0RPRaJc6LdRz 7OaFGCZOq7eYcZhfPKKLtgLpvvJ7Fa2VGY5/WfCM6Lm/rca3Gi/A6GMOfnP8jsE+rET2LoSduqBY4 H9nrorUsAsKdMSbgXAAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHiXD-00Gtan-RI; Sat, 30 Jul 2022 09:13:23 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHiX0-00GtRW-AE; Sat, 30 Jul 2022 09:13:11 +0000 Received: by mail-ej1-x632.google.com with SMTP id gk3so77597ejb.8; Sat, 30 Jul 2022 02:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F8fhUxE3x4wOe3m4a14najZDDA734PpdZ0zvY9IBgdA=; b=ZG2IrV2r1EWLt75BM97iRoI2Fc0pagt70o4R2poxmBf1kaPFF05otKfuGf7gXtlNu+ /dCPH7viH0STK8OcySYRw+QBBy73BSHjr+CT0al1b+vpb2imlIe74RmeRrf9pQqUJaH5 TmBS8LD7rue5YdqAeAFvd+htM27uzgkRJKkN/kfIiTlXZVxmf1bjlsTP2BM0P0T1kNv7 XoxF9QpD+8/TlHICB89Z2XN/1dNWdNao5r8EoIVdL+YOvRB+TDYnU99NpmticLyjn5B1 8h1LYPxQE/lZczOWieZs/hZZCk2VgzErcnMC5xg6qLsBux25HfhSNtlgrJRdhFhQT/L2 aydg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F8fhUxE3x4wOe3m4a14najZDDA734PpdZ0zvY9IBgdA=; b=C1a/ZHzShjjAzMzZGBAv1uWl0IvYPNpx9HXI+7vM13yhFjDXf5oFtopOG3+/cS1CeI vFtw7/syW6uQiIcgb3zPGhSAyCX/++a2HiJSaxflCwLDIEFLVwhH9x8ucVy0eBHTc/VD JuSDYfn/eBeTHVWUprUTH7gc473XUAxrFyXRZbGuRtd1bkbtqh31BBY4u6p0fBW42F+x Xj0HKECY5yiX/5KnlePfUV7jB8l3Zyrfc2BvM/F3Qh5jwvCS3wl4OgbVGHFfP0l6MEhS zl+tDUyW96qSKD/Op3+G2S9z49PTK9XETbGP3/NtwkUNrEy7jxO3LLZ4UegQVy23qzB1 QdSA== X-Gm-Message-State: AJIora92l0nUrEIth9WDfyjSSR3+XT0onXFWxkxrMeOTsJrJ+pkQxrW3 h0JUOnypPzdK2rdTJzItp+o= X-Google-Smtp-Source: AGRyM1vnGZx3SWdOvFK05YcUTuAQpbJMQBq6meu894/eIUroxXOHiUFMsPL5aHg++vyEFuUAzaEVrw== X-Received: by 2002:a17:907:948e:b0:72d:3fd2:5da0 with SMTP id dm14-20020a170907948e00b0072d3fd25da0mr5613928ejc.225.1659172387794; Sat, 30 Jul 2022 02:13:07 -0700 (PDT) Received: from jernej-laptop.localnet (194-152-27-124.dynamic.telemach.net. [194.152.27.124]) by smtp.gmail.com with ESMTPSA id j10-20020a17090623ea00b0072b616ade26sm1344215ejg.216.2022.07.30.02.13.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Jul 2022 02:13:07 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Martin Blumenstingl , Chen-Yu Tsai , Philipp Zabel , Jerome Brunet , Samuel Holland , Thomas Zimmermann , Daniel Vetter , Emma Anholt , David Airlie , Maarten Lankhorst , Noralf =?ISO-8859-1?Q?Tr=F8nnes?= , Kevin Hilman , Neil Armstrong , Maxime Ripard , Maxime Ripard Cc: Maxime Ripard , linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Phil Elwell , Mateusz Kwiatkowski , linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven , Dave Stevenson , linux-amlogic@lists.infradead.org, dri-devel@lists.freedesktop.org, Dom Cobley Subject: Re: [PATCH v1 25/35] drm/sun4i: tv: Remove unused mode_valid Date: Sat, 30 Jul 2022 11:13:05 +0200 Message-ID: <5587265.DvuYhMxLoT@jernej-laptop> In-Reply-To: <20220728-rpi-analog-tv-properties-v1-25-3d53ae722097@cerno.tech> References: <20220728-rpi-analog-tv-properties-v1-0-3d53ae722097@cerno.tech> <20220728-rpi-analog-tv-properties-v1-25-3d53ae722097@cerno.tech> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220730_021310_398002_449803FF X-CRM114-Status: GOOD ( 12.21 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Dne petek, 29. julij 2022 ob 18:35:08 CEST je Maxime Ripard napisal(a): > The mode_valid implementation is pretty much a nop, let's remove it. > > Signed-off-by: Maxime Ripard Reviewed-by: Jernej Skrabec Best regards, Jernej > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c > b/drivers/gpu/drm/sun4i/sun4i_tv.c index 94883abe0dfd..53152d77c392 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_tv.c > +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c > @@ -497,16 +497,8 @@ static int sun4i_tv_comp_get_modes(struct drm_connector > *connector) return i; > } > > -static int sun4i_tv_comp_mode_valid(struct drm_connector *connector, > - struct drm_display_mode *mode) > -{ > - /* TODO */ > - return MODE_OK; > -} > - > static const struct drm_connector_helper_funcs > sun4i_tv_comp_connector_helper_funcs = { .get_modes = > sun4i_tv_comp_get_modes, > - .mode_valid = sun4i_tv_comp_mode_valid, > }; > > static void _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 511E9C04A68 for ; Sat, 30 Jul 2022 09:14:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t2aRCLp2pl+Y6HwS4jJcAOiAZJ75jqKVe5kC/os6xno=; b=zDb/aDaKd6zCGn Uz80pGmJ4n4tLCbKg4SxSHsvRH6xcpeja01IAWKN0uVPKb8sdIJj2fYDhDFo8CY4vhUDCg8M0mR9b jKEHFMXYoWrDQR7WpXuNyLkUzs0ceyPlEXYLrEuZDXSROOdA0FsxZPdyVUit4CABSY30eJ6dPVT+C dNikIE7xD8OTkZ7LdPdD1v/nict75LGauxSyl/SYR7AUfTc7cTV2OkXBB8l7SJQfIi6trEGqY4UMs mdN8LqWht938DGEZ6y98k2lYA2j3uxi73StvROkBtc1YXDvFB+KZwG4BNv+cjN8ySqRL+6G8ShGk7 CG3Gl026yMVk4T38FliA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHiX3-00GtTy-B7; Sat, 30 Jul 2022 09:13:13 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oHiX0-00GtRW-AE; Sat, 30 Jul 2022 09:13:11 +0000 Received: by mail-ej1-x632.google.com with SMTP id gk3so77597ejb.8; Sat, 30 Jul 2022 02:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F8fhUxE3x4wOe3m4a14najZDDA734PpdZ0zvY9IBgdA=; b=ZG2IrV2r1EWLt75BM97iRoI2Fc0pagt70o4R2poxmBf1kaPFF05otKfuGf7gXtlNu+ /dCPH7viH0STK8OcySYRw+QBBy73BSHjr+CT0al1b+vpb2imlIe74RmeRrf9pQqUJaH5 TmBS8LD7rue5YdqAeAFvd+htM27uzgkRJKkN/kfIiTlXZVxmf1bjlsTP2BM0P0T1kNv7 XoxF9QpD+8/TlHICB89Z2XN/1dNWdNao5r8EoIVdL+YOvRB+TDYnU99NpmticLyjn5B1 8h1LYPxQE/lZczOWieZs/hZZCk2VgzErcnMC5xg6qLsBux25HfhSNtlgrJRdhFhQT/L2 aydg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F8fhUxE3x4wOe3m4a14najZDDA734PpdZ0zvY9IBgdA=; b=C1a/ZHzShjjAzMzZGBAv1uWl0IvYPNpx9HXI+7vM13yhFjDXf5oFtopOG3+/cS1CeI vFtw7/syW6uQiIcgb3zPGhSAyCX/++a2HiJSaxflCwLDIEFLVwhH9x8ucVy0eBHTc/VD JuSDYfn/eBeTHVWUprUTH7gc473XUAxrFyXRZbGuRtd1bkbtqh31BBY4u6p0fBW42F+x Xj0HKECY5yiX/5KnlePfUV7jB8l3Zyrfc2BvM/F3Qh5jwvCS3wl4OgbVGHFfP0l6MEhS zl+tDUyW96qSKD/Op3+G2S9z49PTK9XETbGP3/NtwkUNrEy7jxO3LLZ4UegQVy23qzB1 QdSA== X-Gm-Message-State: AJIora92l0nUrEIth9WDfyjSSR3+XT0onXFWxkxrMeOTsJrJ+pkQxrW3 h0JUOnypPzdK2rdTJzItp+o= X-Google-Smtp-Source: AGRyM1vnGZx3SWdOvFK05YcUTuAQpbJMQBq6meu894/eIUroxXOHiUFMsPL5aHg++vyEFuUAzaEVrw== X-Received: by 2002:a17:907:948e:b0:72d:3fd2:5da0 with SMTP id dm14-20020a170907948e00b0072d3fd25da0mr5613928ejc.225.1659172387794; Sat, 30 Jul 2022 02:13:07 -0700 (PDT) Received: from jernej-laptop.localnet (194-152-27-124.dynamic.telemach.net. [194.152.27.124]) by smtp.gmail.com with ESMTPSA id j10-20020a17090623ea00b0072b616ade26sm1344215ejg.216.2022.07.30.02.13.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Jul 2022 02:13:07 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Martin Blumenstingl , Chen-Yu Tsai , Philipp Zabel , Jerome Brunet , Samuel Holland , Thomas Zimmermann , Daniel Vetter , Emma Anholt , David Airlie , Maarten Lankhorst , Noralf =?ISO-8859-1?Q?Tr=F8nnes?= , Kevin Hilman , Neil Armstrong , Maxime Ripard , Maxime Ripard Cc: Maxime Ripard , linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Phil Elwell , Mateusz Kwiatkowski , linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven , Dave Stevenson , linux-amlogic@lists.infradead.org, dri-devel@lists.freedesktop.org, Dom Cobley Subject: Re: [PATCH v1 25/35] drm/sun4i: tv: Remove unused mode_valid Date: Sat, 30 Jul 2022 11:13:05 +0200 Message-ID: <5587265.DvuYhMxLoT@jernej-laptop> In-Reply-To: <20220728-rpi-analog-tv-properties-v1-25-3d53ae722097@cerno.tech> References: <20220728-rpi-analog-tv-properties-v1-0-3d53ae722097@cerno.tech> <20220728-rpi-analog-tv-properties-v1-25-3d53ae722097@cerno.tech> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220730_021310_398002_449803FF X-CRM114-Status: GOOD ( 12.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne petek, 29. julij 2022 ob 18:35:08 CEST je Maxime Ripard napisal(a): > The mode_valid implementation is pretty much a nop, let's remove it. > > Signed-off-by: Maxime Ripard Reviewed-by: Jernej Skrabec Best regards, Jernej > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c > b/drivers/gpu/drm/sun4i/sun4i_tv.c index 94883abe0dfd..53152d77c392 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_tv.c > +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c > @@ -497,16 +497,8 @@ static int sun4i_tv_comp_get_modes(struct drm_connector > *connector) return i; > } > > -static int sun4i_tv_comp_mode_valid(struct drm_connector *connector, > - struct drm_display_mode *mode) > -{ > - /* TODO */ > - return MODE_OK; > -} > - > static const struct drm_connector_helper_funcs > sun4i_tv_comp_connector_helper_funcs = { .get_modes = > sun4i_tv_comp_get_modes, > - .mode_valid = sun4i_tv_comp_mode_valid, > }; > > static void _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel