From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z75at-00024l-W8 for qemu-devel@nongnu.org; Mon, 22 Jun 2015 13:33:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z75ap-0003KY-V7 for qemu-devel@nongnu.org; Mon, 22 Jun 2015 13:33:15 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51932 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z75ap-0003KO-PN for qemu-devel@nongnu.org; Mon, 22 Jun 2015 13:33:11 -0400 Message-ID: <558846D6.4080602@suse.de> Date: Mon, 22 Jun 2015 19:33:10 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <3735588e6f472378c99b595f2502e13013726e56.1434432813.git.crosthwaite.peter@gmail.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 3/4] arm: boot: Use cpu_set_pc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: Peter Maydell , Peter Crosthwaite , QEMU Developers , "Edgar E. Iglesias" Am 16.06.2015 um 13:32 schrieb Peter Maydell: > On 16 June 2015 at 06:46, Peter Crosthwaite wrote: >> Use cpu_set_pc across the board for setting program counters. This >> removes instances of system level code having to reach into the CPU >> env. >> >> Signed-off-by: Peter Crosthwaite >> --- >=20 > Reviewed-by: Peter Maydell Reviewed-by: Andreas F=C3=A4rber >=20 > though you'll want to drop the &error_abort argument to > cpu_set_pc() (see my review on patch 1). Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; = HRB 21284 (AG N=C3=BCrnberg)