From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753900AbbFWGy2 (ORCPT ); Tue, 23 Jun 2015 02:54:28 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:62134 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753226AbbFWGyO (ORCPT ); Tue, 23 Jun 2015 02:54:14 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-9b-558902937bb7 Message-id: <55890291.4010301@samsung.com> Date: Tue, 23 Jun 2015 08:54:09 +0200 From: Krzysztof Opasiak User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-version: 1.0 To: Ruslan Bilovol , balbi@ti.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stern@rowland.harvard.edu, peter.chen@freescale.com, gregkh@linuxfoundation.org, andrzej.p@samsung.com, maxime.ripard@free-electrons.com Subject: Re: [PATCH v5 2/5] usb: gadget: configfs: pass UDC name via usb_gadget_driver struct References: <1435010474-13419-1-git-send-email-ruslan.bilovol@gmail.com> <1435010474-13419-3-git-send-email-ruslan.bilovol@gmail.com> In-reply-to: <1435010474-13419-3-git-send-email-ruslan.bilovol@gmail.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKLMWRmVeSWpSXmKPExsVy+t/xy7qTmTpDDY7Mk7GY9bKdxeLg/XqL 5sXr2Swu75rDZrFoWSuzxdZNe5ktjs3+y2TRs/MEo8WE3xfYHDg9nmy6yOjx73A/k8fOWXfZ PfbPXcPuMfvuD0aPvi2rGD2O39jO5PF5k1wARxSXTUpqTmZZapG+XQJXxvapx5kKdgpWzJ98 la2BcSpfFyMnh4SAicSNldeZIWwxiQv31rN1MXJxCAksZZSYuusnE4TznFFi4+aJrCBVvAJa EvtOdYHZLAKqEt17lwN1cHCwCehLzNslChIWFYiQmH/sNTNEuaDEj8n3WEBsEQFridMdJ1hB ZjILnGaUmLToHyNIQlggXuL63R3MEMvaGSUaz/wC6+YU8JSYNe0GmM0sYCux4P06FghbXmLz mrfMExgFZiFZMgtJ2SwkZQsYmVcxiqaWJhcUJ6XnGuoVJ+YWl+al6yXn525ihETGlx2Mi49Z HWIU4GBU4uEtmNwRKsSaWFZcmXuIUYKDWUmEd+1NoBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHe ubvehwgJpCeWpGanphakFsFkmTg4pRoYXdY3rvu8fyHX88zoSsHYGt+Hopc++57RzFk74ZOR zplZ3KlMzi//pMwVC5d92tl8O7lU+nq16zHJPS+4jD5+9bg6c0Pe5fxyL+lZ3VO8z3K7Jthx aGwuDMqLv1j4MaV2qvyG+C6WB0tcXvIYVa17JFRTm8XgfeiyzLcaNqYCr5N3uMWy7+5UYinO SDTUYi4qTgQAojMME4gCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 06/23/2015 12:01 AM, Ruslan Bilovol wrote: > Now when udc-core supports binding to specific UDC by passing > its name via 'udc_name' member of usb_gadget_driver struct, > switch to this generic approach. > > Tested-by: Maxime Ripard > Signed-off-by: Ruslan Bilovol > --- > drivers/usb/gadget/configfs.c | 27 ++++++++++++++------------- > 1 file changed, 14 insertions(+), 13 deletions(-) > > diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c > index c42765b..efad021 100644 > --- a/drivers/usb/gadget/configfs.c > +++ b/drivers/usb/gadget/configfs.c > @@ -54,7 +54,6 @@ struct gadget_info { > struct list_head string_list; > struct list_head available_func; > > - const char *udc_name; > #ifdef CONFIG_USB_OTG > struct usb_otg_descriptor otg; > #endif > @@ -230,21 +229,21 @@ static ssize_t gadget_dev_desc_bcdUSB_store(struct gadget_info *gi, > > static ssize_t gadget_dev_desc_UDC_show(struct gadget_info *gi, char *page) > { > - return sprintf(page, "%s\n", gi->udc_name ?: ""); > + return sprintf(page, "%s\n", gi->composite.gadget_driver.udc_name ?: ""); > } > > static int unregister_gadget(struct gadget_info *gi) > { > int ret; > > - if (!gi->udc_name) > + if (!gi->composite.gadget_driver.udc_name) > return -ENODEV; > > ret = usb_gadget_unregister_driver(&gi->composite.gadget_driver); > if (ret) > return ret; > - kfree(gi->udc_name); > - gi->udc_name = NULL; > + kfree(gi->composite.gadget_driver.udc_name); > + gi->composite.gadget_driver.udc_name = NULL; > return 0; > } > > @@ -267,14 +266,16 @@ static ssize_t gadget_dev_desc_UDC_store(struct gadget_info *gi, > if (ret) > goto err; > } else { > - if (gi->udc_name) { > + if (gi->composite.gadget_driver.udc_name) { You are using this very long if condition in a few places, maybe it would be more suitable to define a macro or inline function for this? Something like gadget_dev_bound() or gadget_dev_is_active() or some other more suitable name. Best regards, -- Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/