From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] drivers: xen-blkfront: only talk_to_blkback() when in XenbusStateInitialising Date: Tue, 23 Jun 2015 07:23:59 +0100 Message-ID: <5589179F0200007800087E6E__15296.760274987$1435040750$gmane$org@mail.emea.novell.com> References: <558762C4.2000002@oracle.com> <1434981360-29794-1-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z7Hco-00058E-QN for xen-devel@lists.xenproject.org; Tue, 23 Jun 2015 06:24:02 +0000 In-Reply-To: <1434981360-29794-1-git-send-email-konrad.wilk@oracle.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Rafal.Mielniczuk@citrix.com, linux-kernel@vger.kernel.org, marcus.granado@citrix.com, julien.grall@citrix.com, justing@spectralogic.com, Paul.Durrant@citrix.com, david.vrabel@citrix.com, xen-devel@lists.xenproject.org, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org >>> On 22.06.15 at 15:56, wrote: > --- a/drivers/block/xen-blkfront.c > +++ b/drivers/block/xen-blkfront.c > @@ -1951,6 +1951,8 @@ static void blkback_changed(struct xenbus_device *dev, > > switch (backend_state) { > case XenbusStateInitWait: > + if (dev->state != XenbusStateInitialising) > + break; If, as you say in a subsequent reply, all other drivers already have such a check, wouldn't it make more sense to put this into xenbus' backend_changed() or even xenbus_otherend_changed()? Jan