From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH 6/9] x86/pvh: Properly set HYPERVISOR_COMPAT_VIRT_START for PVH guests Date: Tue, 23 Jun 2015 14:25:36 +0100 Message-ID: <55897A70020000780008853A@mail.emea.novell.com> References: <1434769773-5157-1-git-send-email-boris.ostrovsky@oracle.com> <1434769773-5157-7-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1434769773-5157-7-git-send-email-boris.ostrovsky@oracle.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky Cc: elena.ufimtseva@oracle.com, Keir Fraser , Andrew Cooper , tim@xen.org, xen-devel@lists.xen.org, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org >>> On 20.06.15 at 05:09, wrote: > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -584,7 +584,7 @@ int arch_domain_create(struct domain *d, unsigned int > domcr_flags, > mapcache_domain_init(d); > > HYPERVISOR_COMPAT_VIRT_START(d) = > - is_pv_domain(d) ? __HYPERVISOR_COMPAT_VIRT_START : ~0u; > + is_hvm_domain(d) ? ~0u : __HYPERVISOR_COMPAT_VIRT_START; Why would a PVH domain be different in this respect from a HVM one? Jan