From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754859AbbFWPuE (ORCPT ); Tue, 23 Jun 2015 11:50:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53328 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753479AbbFWPtz (ORCPT ); Tue, 23 Jun 2015 11:49:55 -0400 Message-ID: <5589801A.2090203@redhat.com> Date: Tue, 23 Jun 2015 17:49:46 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Feng Wu , kvm@vger.kernel.org, linux-kernel@vger.kernel.org CC: mtosatti@redhat.com, alex.williamson@redhat.com, eric.auger@linaro.org Subject: Re: [v4 01/16] KVM: Extend struct pi_desc for VT-d Posted-Interrupts References: <1434019912-15423-1-git-send-email-feng.wu@intel.com> <1434019912-15423-2-git-send-email-feng.wu@intel.com> In-Reply-To: <1434019912-15423-2-git-send-email-feng.wu@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/06/2015 12:51, Feng Wu wrote: > + union { > + struct { > + /* bit 256 - Outstanding Notification */ > + u64 on : 1, > + /* bit 257 - Suppress Notification */ > + sn : 1, > + /* bit 271:258 - Reserved */ > + rsvd_1 : 14, > + /* bit 279:272 - Notification Vector */ > + nv : 8, > + /* bit 287:280 - Reserved */ > + rsvd_2 : 8, > + /* bit 319:288 - Notification Destination */ > + ndst : 32; Please do not use bitfields, Linus doesn't like them. Use static inlines instead to extract or set the fields from the control field. Paolo > + }; > + u64 control; > + }; > + u32 rsvd[6];