From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7QXt-0007QS-7U for qemu-devel@nongnu.org; Tue, 23 Jun 2015 11:55:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7QXs-0000az-Gc for qemu-devel@nongnu.org; Tue, 23 Jun 2015 11:55:33 -0400 Message-ID: <5589816B.8070302@redhat.com> Date: Tue, 23 Jun 2015 11:55:23 -0400 From: John Snow MIME-Version: 1.0 References: <1434765047-29333-1-git-send-email-jsnow@redhat.com> <1434765047-29333-5-git-send-email-jsnow@redhat.com> <20150622140619.GB7136@stefanha-thinkpad.redhat.com> <558816D6.3030400@redhat.com> <20150623134657.GB31481@stefanha-thinkpad.redhat.com> In-Reply-To: <20150623134657.GB31481@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/16] ahci: check for ncq prdtl overflow List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org On 06/23/2015 09:46 AM, Stefan Hajnoczi wrote: > On Mon, Jun 22, 2015 at 10:08:22AM -0400, John Snow wrote: >> (sector_count == 0 means 64K sectors, though, like it does in regular >> ATA.) > > I don't see a case to handle this. > I apologize: Corrected in [PATCH 09/16] ahci: correct ncq sector count, in the "part 2" series. Sorry for the confusing order, I played a lot of patch-reshuffling and due to the refactors to get NCQ migrating, sometimes it was literally just a sin of convenience to leave certain patches after the shuffle. I tried to leave each patch fixing just one very small issue at a time so they were easier to digest, instead of batching them together like "Fix (everything wrong about) sector count." Maybe that wasn't the right approach, you can let me know. Thank you, --John