* [PATCH] minor shared/vcpu info adjustments
@ 2015-06-23 15:09 Jan Beulich
2015-06-23 15:47 ` Andrew Cooper
2015-07-06 16:02 ` Ian Campbell
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2015-06-23 15:09 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Campbell, Keir Fraser, Ian Jackson, Tim Deegan
[-- Attachment #1: Type: text/plain, Size: 1764 bytes --]
- remove vcpu_info from xlat.lst (it isn't and can't be checked)
- drop pointless (redundant) casts
- make dummy_vcpu_info static
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -70,7 +70,7 @@ integer_param("hardware_dom", hardware_d
struct vcpu *idle_vcpu[NR_CPUS] __read_mostly;
-vcpu_info_t dummy_vcpu_info;
+static vcpu_info_t dummy_vcpu_info;
static void __domain_finalise_shutdown(struct domain *d)
{
--- a/xen/include/xen/shared.h
+++ b/xen/include/xen/shared.h
@@ -18,7 +18,7 @@ typedef union {
#define __shared_info(d, s, field) \
(*(!has_32bit_shinfo(d) ? \
(typeof(&(s)->compat.field))&(s)->native.field : \
- (typeof(&(s)->compat.field))&(s)->compat.field))
+ &(s)->compat.field))
typedef union {
struct vcpu_info native;
@@ -29,7 +29,7 @@ typedef union {
#define __vcpu_info(v, i, field) \
(*(!has_32bit_shinfo((v)->domain) ? \
(typeof(&(i)->compat.field))&(i)->native.field : \
- (typeof(&(i)->compat.field))&(i)->compat.field))
+ &(i)->compat.field))
#else
@@ -41,8 +41,6 @@ typedef struct vcpu_info vcpu_info_t;
#endif
-extern vcpu_info_t dummy_vcpu_info;
-
#define shared_info(d, field) __shared_info(d, (d)->shared_info, field)
#define vcpu_info(v, field) __vcpu_info(v, (v)->vcpu_info, field)
--- a/xen/include/xlat.lst
+++ b/xen/include/xlat.lst
@@ -6,7 +6,6 @@
? mmu_update xen.h
! mmuext_op xen.h
! start_info xen.h
-? vcpu_info xen.h
? vcpu_time_info xen.h
! cpu_user_regs arch-x86/xen-@arch@.h
! trap_info arch-x86/xen.h
[-- Attachment #2: shared-info-adjustments.patch --]
[-- Type: text/plain, Size: 1796 bytes --]
minor shared/vcpu info adjustments
- remove vcpu_info from xlat.lst (it isn't and can't be checked)
- drop pointless (redundant) casts
- make dummy_vcpu_info static
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -70,7 +70,7 @@ integer_param("hardware_dom", hardware_d
struct vcpu *idle_vcpu[NR_CPUS] __read_mostly;
-vcpu_info_t dummy_vcpu_info;
+static vcpu_info_t dummy_vcpu_info;
static void __domain_finalise_shutdown(struct domain *d)
{
--- a/xen/include/xen/shared.h
+++ b/xen/include/xen/shared.h
@@ -18,7 +18,7 @@ typedef union {
#define __shared_info(d, s, field) \
(*(!has_32bit_shinfo(d) ? \
(typeof(&(s)->compat.field))&(s)->native.field : \
- (typeof(&(s)->compat.field))&(s)->compat.field))
+ &(s)->compat.field))
typedef union {
struct vcpu_info native;
@@ -29,7 +29,7 @@ typedef union {
#define __vcpu_info(v, i, field) \
(*(!has_32bit_shinfo((v)->domain) ? \
(typeof(&(i)->compat.field))&(i)->native.field : \
- (typeof(&(i)->compat.field))&(i)->compat.field))
+ &(i)->compat.field))
#else
@@ -41,8 +41,6 @@ typedef struct vcpu_info vcpu_info_t;
#endif
-extern vcpu_info_t dummy_vcpu_info;
-
#define shared_info(d, field) __shared_info(d, (d)->shared_info, field)
#define vcpu_info(v, field) __vcpu_info(v, (v)->vcpu_info, field)
--- a/xen/include/xlat.lst
+++ b/xen/include/xlat.lst
@@ -6,7 +6,6 @@
? mmu_update xen.h
! mmuext_op xen.h
! start_info xen.h
-? vcpu_info xen.h
? vcpu_time_info xen.h
! cpu_user_regs arch-x86/xen-@arch@.h
! trap_info arch-x86/xen.h
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] minor shared/vcpu info adjustments
2015-06-23 15:09 [PATCH] minor shared/vcpu info adjustments Jan Beulich
@ 2015-06-23 15:47 ` Andrew Cooper
2015-07-06 16:02 ` Ian Campbell
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2015-06-23 15:47 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Ian Campbell, Ian Jackson, Keir Fraser, Tim Deegan
On 23/06/15 16:09, Jan Beulich wrote:
> - remove vcpu_info from xlat.lst (it isn't and can't be checked)
> - drop pointless (redundant) casts
> - make dummy_vcpu_info static
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] minor shared/vcpu info adjustments
2015-06-23 15:09 [PATCH] minor shared/vcpu info adjustments Jan Beulich
2015-06-23 15:47 ` Andrew Cooper
@ 2015-07-06 16:02 ` Ian Campbell
1 sibling, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2015-07-06 16:02 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, Keir Fraser, Ian Jackson, Tim Deegan
On Tue, 2015-06-23 at 16:09 +0100, Jan Beulich wrote:
> - remove vcpu_info from xlat.lst (it isn't and can't be checked)
> - drop pointless (redundant) casts
> - make dummy_vcpu_info static
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-06 16:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-23 15:09 [PATCH] minor shared/vcpu info adjustments Jan Beulich
2015-06-23 15:47 ` Andrew Cooper
2015-07-06 16:02 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.