From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sun, 21 Mar 2021 19:29:26 +0100 Subject: [PATCH 1/6] usb: Return -ENOSYS when system call is not available In-Reply-To: References: <20210321031824.2170848-1-sjg@chromium.org> <20210321031824.2170848-2-sjg@chromium.org> Message-ID: <5589df4c-b884-ef77-ee82-3495d6736380@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 3/21/21 5:12 AM, Simon Glass wrote: > Hi Marek, > > On Sun, 21 Mar 2021 at 17:09, Marek Vasut wrote: >> >> On 3/21/21 4:18 AM, Simon Glass wrote: >>> Update usb_gadget_release() to use -ENOSYS, which is the correct error >>> code for U-Boot. >> >> It would be good if you could explain _why_ this change is required. Why >> is ENOSYS the correct return value ? It is not clear from the patch >> description, sorry. > > That is the value used throughout driver model, so it is a convention. > As per the cover letter and one on the patches, people are not sure > which one to use, because -ENOTSUPP has crept in in a few places. I agree with Tom, this needs to be documented first, then the document should be agreed upon, and only then should these fixes follow.