From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: elena.ufimtseva@oracle.com, Keir Fraser <keir@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
tim@xen.org, xen-devel@lists.xen.org, roger.pau@citrix.com
Subject: Re: [PATCH 8/9] x86/pvh: Don't try to get l4 table for PVH guests in vcpu_destroy_pagetables()
Date: Tue, 23 Jun 2015 23:05:54 -0400 [thread overview]
Message-ID: <558A1E92.1010702@oracle.com> (raw)
In-Reply-To: <55897D74020000780008858B@mail.emea.novell.com>
On 06/23/2015 09:38 AM, Jan Beulich wrote:
>>>> On 20.06.15 at 05:09, <boris.ostrovsky@oracle.com> wrote:
>> --- a/xen/arch/x86/mm.c
>> +++ b/xen/arch/x86/mm.c
>> @@ -2652,7 +2652,7 @@ int vcpu_destroy_pagetables(struct vcpu *v)
>> if ( rc )
>> return rc;
>>
>> - if ( is_pv_32on64_vcpu(v) )
>> + if ( is_pv_32on64_vcpu(v) && !is_pvh_vcpu(v) )
> This looks wrong - is_pv_32on64_vcpu() should imply is_pv_vcpu()
> and hence !is_pvh_vcpu().
That's because I kept
d->arch.is_32bit_pv = d->arch.has_32bit_shinfo = 1;
in switch_compat() for both PV and PVH. I should probably only set
has_32bit_shinfo for PVH.
-boris
next prev parent reply other threads:[~2015-06-24 3:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 3:09 [PATCH 0/9] 32-bit domU PVH support Boris Ostrovsky
2015-06-20 3:09 ` [PATCH 1/9] x86/pvh: Don't test 64b-only vcpu_guest_context's fields Boris Ostrovsky
2015-06-20 3:09 ` [PATCH 2/9] x86/pvh: Don't copy to/from trap_ctxt for 32b PVH guests Boris Ostrovsky
2015-06-20 3:09 ` [PATCH 3/9] x86/pvh: Properly initialize PVH guest's CR3 Boris Ostrovsky
2015-06-20 3:09 ` [PATCH 4/9] x86/compat: Manage argument translation area separately from l4 Boris Ostrovsky
2015-06-20 3:09 ` [PATCH 5/9] x86/pvh: Set PVH guest's mode in XEN_DOMCTL_set_address_size Boris Ostrovsky
2015-06-23 13:22 ` Jan Beulich
2015-06-24 2:53 ` Boris Ostrovsky
2015-06-24 7:57 ` Jan Beulich
2015-06-24 11:42 ` Boris Ostrovsky
2015-06-24 12:10 ` Jan Beulich
2015-06-24 16:21 ` Boris Ostrovsky
2015-06-25 7:37 ` Jan Beulich
2015-06-20 3:09 ` [PATCH 6/9] x86/pvh: Properly set HYPERVISOR_COMPAT_VIRT_START for PVH guests Boris Ostrovsky
2015-06-23 13:25 ` Jan Beulich
2015-06-24 2:55 ` Boris Ostrovsky
2015-06-20 3:09 ` [PATCH 7/9] x86/pvh: Handle hypercalls for 32b " Boris Ostrovsky
2015-06-23 13:35 ` Jan Beulich
2015-06-20 3:09 ` [PATCH 8/9] x86/pvh: Don't try to get l4 table for PVH guests in vcpu_destroy_pagetables() Boris Ostrovsky
2015-06-23 13:38 ` Jan Beulich
2015-06-24 3:05 ` Boris Ostrovsky [this message]
2015-06-24 7:58 ` Jan Beulich
2015-06-20 3:09 ` [PATCH 9/9] libxc/x86/pvh: Allow creation of 32b PVH guests Boris Ostrovsky
2015-06-22 8:37 ` Ian Campbell
2015-06-20 3:09 ` [PATCH 1/9] x86/pvh: Don't test 64b-only vcpu_guest_context's fields Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558A1E92.1010702@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=elena.ufimtseva@oracle.com \
--cc=keir@xen.org \
--cc=roger.pau@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.