All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: mttcg@greensocs.com, peter.maydell@linaro.org,
	Alexander Spyridakis <a.spyridakis@virtualopensystems.com>,
	mark.burton@greensocs.com, qemu-devel@nongnu.org,
	fred.konrad@greensocs.com
Subject: Re: [Qemu-devel] [RFC PATCH] target-arm/psci.c: wake up sleeping CPUs (MTTCG)
Date: Wed, 24 Jun 2015 19:23:23 +0200	[thread overview]
Message-ID: <558AE78B.90705@redhat.com> (raw)
In-Reply-To: <87y4j9xbxh.fsf@linaro.org>



On 24/06/2015 19:18, Alex Bennée wrote:
>>> >> @@ -196,6 +196,8 @@ void arm_handle_psci_call(ARMCPU *cpu)
>>> >>          }
>>> >>          target_cpu_class->set_pc(target_cpu_state, entry);
>>> >>  
>>> >> +        qemu_cond_signal(target_cpu_state->halt_cond);
>> >
>> > That's called qemu_cpu_kick(target_cpu_state). :)  The patch should be
>> > acceptable now upstream, I think.
> Oh so this might well fail in KVM too?
> 
> The qemu_cpu_kick does a qemu_cond_broadcast(cpu->halt_cond) which seems
> a little excessive? Won't all sleeping CPUs wake up (and return to sleep)?

On KVM (and I assume on MT-TCG), each CPU has a different halt_cond.

Paolo

  reply	other threads:[~2015-06-24 17:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24 15:34 [Qemu-devel] [RFC PATCH] target-arm/psci.c: wake up sleeping CPUs (MTTCG) Alex Bennée
2015-06-24 16:01 ` Paolo Bonzini
2015-06-24 17:18   ` Alex Bennée
2015-06-24 17:23     ` Paolo Bonzini [this message]
2015-06-24 18:15       ` Alex Bennée
2015-06-24 19:12     ` Peter Maydell
2015-06-25 15:44       ` Andrew Jones
2015-06-26  7:06         ` Alex Bennée
2015-06-26  8:05           ` Andrew Jones
2015-06-24 23:55 ` Alexander Spyridakis
2015-06-25  6:27   ` Alex Bennée
2015-06-25 12:43   ` Frederic Konrad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558AE78B.90705@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=a.spyridakis@virtualopensystems.com \
    --cc=alex.bennee@linaro.org \
    --cc=fred.konrad@greensocs.com \
    --cc=mark.burton@greensocs.com \
    --cc=mttcg@greensocs.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.