From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v4 11/17] x86/hvm: only call hvm_io_assist() from hvm_wait_for_io() Date: Wed, 24 Jun 2015 16:36:32 +0100 Message-ID: <558AEAA002000078000890AC@mail.emea.novell.com> References: <1435145089-21999-1-git-send-email-paul.durrant@citrix.com> <1435145089-21999-12-git-send-email-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z7mj6-0002WO-GO for xen-devel@lists.xenproject.org; Wed, 24 Jun 2015 15:36:36 +0000 In-Reply-To: <1435145089-21999-12-git-send-email-paul.durrant@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Paul Durrant Cc: Andrew Cooper , Keir Fraser , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org >>> On 24.06.15 at 13:24, wrote: > By removing the calls in hvmemul_do_io() (which is replaced by a single > assignment) and hvm_complete_assist_request() (which is replaced by a > call to process_portio_intercept() with a suitable set of ops) then With this saying hvm_process_io_intercept() ... > hvm_io_assist() can be moved into hvm.c and made static (and hence be a > candidate for inlining). > > This patch also fixes the I/O state test at the end of hvm_io_assist() > to check the correct value. Since the ioreq server patch series was > integrated the current ioreq state is no longer an indicator of in-flight > I/O state, since an I/O sheduled by re-emulation may be targetted at a > different ioreq server. > > Signed-off-by: Paul Durrant Acked-by: Jan Beulich