All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexei Starovoitov <ast@plumgrid.com>
To: Wang Nan <wangnan0@huawei.com>,
	acme@kernel.org, brendan.d.gregg@gmail.com, daniel@iogearbox.net,
	namhyung@kernel.org, masami.hiramatsu.pt@hitachi.com,
	paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com,
	jolsa@kernel.org, dsahern@gmail.com
Cc: linux-kernel@vger.kernel.org, lizefan@huawei.com,
	hekuang@huawei.com, xiakaixu@huawei.com, pi3orama@163.com
Subject: Re: [RFC PATCH 3/3] perf tools: Support attach BPF program on uprobe events
Date: Fri, 26 Jun 2015 01:47:32 -0700	[thread overview]
Message-ID: <558D11A4.5020102@plumgrid.com> (raw)
In-Reply-To: <1435228645-116055-4-git-send-email-wangnan0@huawei.com>

On 6/25/15 3:37 AM, Wang Nan wrote:
> This patch append new syntax to BPF object section name to support
> probing at uprobe event. Now we can use BPF program like this:
>
>   SEC(
>   "target:/lib64/libc.so.6\n"
>   "libcwrite=__write"
>   )
>   int libcwrite(void *ctx)
>   {
>       return 1;
>   }
>
> Where, in section name of a program, before the main config string,
> we can use 'key:value' style options. Now the only option key "target"
> is for uprobe probing.
>
> Signed-off-by: Wang Nan<wangnan0@huawei.com>

looks good.
why use ':' separator? '=' should work as well and will be more
consistent ?

  reply	other threads:[~2015-06-26  8:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 10:37 [RFC PATCH 0/3] tracing, perf tools: Attach BPF program on uprobe events Wang Nan
2015-06-25 10:37 ` [RFC PATCH 1/3] perf probe: Init symbol as kprobe if any pev is kprobe Wang Nan
2015-06-26  8:49   ` Alexei Starovoitov
2015-06-27  7:29   ` Masami Hiramatsu
2015-06-27  7:34     ` Wangnan (F)
2015-06-27  8:30       ` Masami Hiramatsu
2015-06-27 11:15         ` Wangnan (F)
2015-06-25 10:37 ` [RFC PATCH 2/3] tracing, perf: Implement BPF programs attached to uprobes Wang Nan
2015-06-26  8:45   ` Alexei Starovoitov
2015-06-25 10:37 ` [RFC PATCH 3/3] perf tools: Support attach BPF program on uprobe events Wang Nan
2015-06-26  8:47   ` Alexei Starovoitov [this message]
2015-06-26 11:09     ` Wangnan (F)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558D11A4.5020102@plumgrid.com \
    --to=ast@plumgrid.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=brendan.d.gregg@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=dsahern@gmail.com \
    --cc=hekuang@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    --cc=pi3orama@163.com \
    --cc=wangnan0@huawei.com \
    --cc=xiakaixu@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.