From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH V2 2/3] xen/vm_event: Support for guest-requested events Date: Fri, 26 Jun 2015 09:45:38 +0100 Message-ID: <558D2D52020000780008A06D@mail.emea.novell.com> References: <1434359007-9302-1-git-send-email-rcojocaru@bitdefender.com> <1434359007-9302-3-git-send-email-rcojocaru@bitdefender.com> <558D152B0200007800089FD4@mail.emea.novell.com> <558CFC75.9000905@bitdefender.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <558CFC75.9000905@bitdefender.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Razvan Cojocaru Cc: tim@xen.org, kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, jun.nakajima@intel.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, eddie.dong@intel.com, Aravind.Gopalakrishnan@amd.com, suravee.suthikulpanit@amd.com, keir@xen.org, boris.ostrovsky@oracle.com, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org >>> On 26.06.15 at 09:17, wrote: > On 06/26/2015 10:02 AM, Jan Beulich wrote: >>>>> On 15.06.15 at 11:03, wrote: >>> --- a/xen/include/public/hvm/hvm_op.h >>> +++ b/xen/include/public/hvm/hvm_op.h >>> @@ -389,6 +389,10 @@ DEFINE_XEN_GUEST_HANDLE(xen_hvm_evtchn_upcall_vector_t); >>> >>> #endif /* defined(__i386__) || defined(__x86_64__) */ >>> >>> +#if defined(__XEN__) || defined(__XEN_TOOLS__) >>> +#define HVMOP_request_vm_event 24 >>> +#endif /* defined(__XEN__) || defined(__XEN_TOOLS__) */ >> >> Isn't this _specifically_ meant to be usable by a guest? > > Yes, but we still need Xen tools to subscribe to the events, control how > they are received (in a dom0 or similarly privileged domain) and process > them. That was my train of thought anyway, maybe I'm missing something > (or I'm misinterpreting the macros). The way it's done above you _limit_ the #define's visibility to Xen and the tool stack, i.e. you namely exclude guests from seeing (and hence using) it. Jan