From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752290AbbFZTWw (ORCPT ); Fri, 26 Jun 2015 15:22:52 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:43403 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751829AbbFZTWn (ORCPT ); Fri, 26 Jun 2015 15:22:43 -0400 Message-ID: <558DA679.7000304@fb.com> Date: Fri, 26 Jun 2015 13:22:33 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Junichi Nomura , "torvalds@linuxfoundation.org" CC: "linux-kernel@vger.kernel.org" , Christoph Hellwig , Mike Snitzer , device-mapper development Subject: Re: [GIT PULL] Core block IO bits for 4.2 References: <20150625143716.GA13739@kernel.dk> <20150626061510.GA15036@xzibit.linux.bs1.fc.nec.co.jp> In-Reply-To: <20150626061510.GA15036@xzibit.linux.bs1.fc.nec.co.jp> Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-06-26_06:2015-06-26,2015-06-26,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/26/2015 12:15 AM, Junichi Nomura wrote: > Hi Jens, > > On 06/25/15 23:37, Jens Axboe wrote: >> block, dm: don't copy bios for request clones > > this change should not be pushed to mainline yet. > > Firstly, Christoph has a newer version of the patch that fixes silent > data corruption problem: > https://www.redhat.com/archives/dm-devel/2015-May/msg00229.html > > And the new version still depends on LLDDs to always complete requests > to the end when error happens, while block API doesn't enforce such a > requirement. If the assumption is ever broken, the inconsistency between > request and bio (e.g. rq->__sector and rq->bio) will cause silent data > corruption: > https://www.redhat.com/archives/dm-devel/2015-June/msg00022.html Why was none of that sent to the block tree? In any case, Linus, pick up Mike's pull request to fix this up. -- Jens Axboe