All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Yun-hao Chung <howardchung@google.com>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	Bluez mailing list <linux-bluetooth@vger.kernel.org>,
	ChromeOS BT Qualification <chromeos-bt-qual@google.com>
Subject: Re: Should we disable ERTM as default?
Date: Mon, 8 Jun 2020 09:58:02 +0200	[thread overview]
Message-ID: <558DADDA-AC07-4463-A94E-085B16976AAB@holtmann.org> (raw)
In-Reply-To: <CAPHZWUd=t6icDXpz=td0teDoKHtE6FMH3OPE5R+BH53GOrXAdg@mail.gmail.com>

Hi Yun-hao,

> I think it is more likely to be the PTS's limitations. I realized the
> problem is in the media channel not in the signaling channel. PTS
> wants to use streaming mode, but bluez rejects it, and then PTS aborts
> the test. According to the MPS 1.0 Spec 6.2, L2CAP streaming mode is
> the recommendation for optimization when using MPS media control
> channels, so I think bluez doesn't do anything wrong during this test.

do you have the btmon trace for this. I think we should accept ERTM on the media channel. The unfortunate part is that control and media channels both use PSM 25 and so we can’t be really selective when we are the acceptor. If MPS wants us to accept ERTM on the media channel we should allow. For all I care we can even accept it on the control channel, but it is just a waste of overhead on the L2CAP headers. Actually the new Enhanced Flow Control mode on BR/EDR would be more efficient for A2DP.

Regards

Marcel


  reply	other threads:[~2020-06-08  7:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03 14:04 Should we disable ERTM as default? Yun-hao Chung
2020-06-03 17:40 ` Marcel Holtmann
2020-06-03 19:52   ` Luiz Augusto von Dentz
2020-06-05 11:09     ` Yun-hao Chung
2020-06-08  7:58       ` Marcel Holtmann [this message]
     [not found]         ` <CAPHZWUeo3sAGsgAapYYZTSt_apKvP-2LHOxBbYF_8pcaCzYn1Q@mail.gmail.com>
2020-06-08 16:15           ` Luiz Augusto von Dentz
2020-06-08 16:33             ` Marcel Holtmann
2020-06-08 20:28             ` Luiz Augusto von Dentz
2020-06-12  9:27               ` Yun-hao Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558DADDA-AC07-4463-A94E-085B16976AAB@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=chromeos-bt-qual@google.com \
    --cc=howardchung@google.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.