From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH] ARM: BCM5301X: Enable UART0 for SmartRG SR-400AC Date: Sat, 27 Jun 2015 18:38:20 -0700 Message-ID: <558F500C.6040004@gmail.com> References: <1435103504-28592-1-git-send-email-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Hauke Mehrtens , bcm-kernel-feedback-list , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org Le 06/27/15 15:08, Rafa=C5=82 Mi=C5=82ecki a =C3=A9crit : > On 24 June 2015 at 01:51, Florian Fainelli wro= te: >> Enable the use of UART0 by overriding its default status property. >> >> Signed-off-by: Florian Fainelli >> --- >> arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts b/arch/ar= m/boot/dts/bcm4708-smartrg-sr400ac.dts >> index d6a033b97c70..64a5e8ab65e0 100644 >> --- a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts >> +++ b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts >> @@ -118,3 +118,7 @@ >> }; >> }; >> }; >> + >> +&uart0 { >> + status =3D "okay"; >> +}; >=20 > We have many more changes like this in OpenWrt, I just didn't upstrea= m > them because of current chipcommonA state. >=20 > It was added before we got "brcm,bus-axi" and I believe Hauke wanted > move it to the "correct" place at some point. Since UART is part of > ChipCommon device and ChipCommon is part of "brcm,bus-axi",.I guess w= e > should add UARTs as a ChipCommon device subnodes. We already have > chipcommon: chipcommon@0 { > reg =3D <0x00000000 0x1000>; >=20 > gpio-controller; > #gpio-cells =3D <2>; > }; > , is it possible to move UARTs there? >=20 > I'm not sure if this UART cleanup should block your change. I guess i= t > depends on the way it'll finally look like. I do not think it will, see below: >=20 > I'm also wondering: is there any preference between overwriting statu= s > with something like > &uart0 { }; > and > chipcommonA { > uart0: serial@0300 { }; > }; > ? I don't know DT that well, just asking. An alias can be located pretty much anywhere in the DTS as long as the name is unique, which is why I took this approach, because I do not hav= e to do something like this and need to know the full depth of the tree: foo0 { bar0 { baz0 { status =3D "okay"; }; }; }; This is both more compact, and more robust to re-parenting the UART0 node in case you ever wanted to do it in the future. I will happily fix the other DTSes to use that convention if we agree this is the route to take. Thanks! -- =46lorian -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: f.fainelli@gmail.com (Florian Fainelli) Date: Sat, 27 Jun 2015 18:38:20 -0700 Subject: [PATCH] ARM: BCM5301X: Enable UART0 for SmartRG SR-400AC In-Reply-To: References: <1435103504-28592-1-git-send-email-f.fainelli@gmail.com> Message-ID: <558F500C.6040004@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le 06/27/15 15:08, Rafa? Mi?ecki a ?crit : > On 24 June 2015 at 01:51, Florian Fainelli wrote: >> Enable the use of UART0 by overriding its default status property. >> >> Signed-off-by: Florian Fainelli >> --- >> arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts >> index d6a033b97c70..64a5e8ab65e0 100644 >> --- a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts >> +++ b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts >> @@ -118,3 +118,7 @@ >> }; >> }; >> }; >> + >> +&uart0 { >> + status = "okay"; >> +}; > > We have many more changes like this in OpenWrt, I just didn't upstream > them because of current chipcommonA state. > > It was added before we got "brcm,bus-axi" and I believe Hauke wanted > move it to the "correct" place at some point. Since UART is part of > ChipCommon device and ChipCommon is part of "brcm,bus-axi",.I guess we > should add UARTs as a ChipCommon device subnodes. We already have > chipcommon: chipcommon at 0 { > reg = <0x00000000 0x1000>; > > gpio-controller; > #gpio-cells = <2>; > }; > , is it possible to move UARTs there? > > I'm not sure if this UART cleanup should block your change. I guess it > depends on the way it'll finally look like. I do not think it will, see below: > > I'm also wondering: is there any preference between overwriting status > with something like > &uart0 { }; > and > chipcommonA { > uart0: serial at 0300 { }; > }; > ? I don't know DT that well, just asking. An alias can be located pretty much anywhere in the DTS as long as the name is unique, which is why I took this approach, because I do not have to do something like this and need to know the full depth of the tree: foo0 { bar0 { baz0 { status = "okay"; }; }; }; This is both more compact, and more robust to re-parenting the UART0 node in case you ever wanted to do it in the future. I will happily fix the other DTSes to use that convention if we agree this is the route to take. Thanks! -- Florian