From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [v4][PATCH 11/19] tools: introduce some new parameters to set rdm policy Date: Mon, 29 Jun 2015 09:01:13 +0800 Message-ID: <559098D9.7000000@intel.com> References: <1435053450-25131-1-git-send-email-tiejun.chen@intel.com> <1435053450-25131-12-git-send-email-tiejun.chen@intel.com> <1435234395.32500.73.camel@citrix.com> <558D0F98.7020107@intel.com> <1435309027.32500.142.camel@citrix.com> <558D1D13.2010208@intel.com> <20150626120646.GA1609@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150626120646.GA1609@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Stefano Stabellini , Ian Jackson , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org >>>> Just let me rephrase this, >>>> >>>> "none" means we don't check any reserved regions and then all rdm >>>> policies would be ignored, so guest just work as before. >>> >>> When or why would I write: >>> rdm = "none" >>> in my configuration file instead of just not saying anything? >> >> As you know we just have two options, "none" vs. "host". So we need a >> explicit flag as a default libxl value to work out our mechanism. >> >> +libxl_rdm_reserve_type = Enumeration("rdm_reserve_type", [ >> + (0, "none"), >> + (1, "host"), >> + ]) >> + >> >> We just think this name can make sense, right? >> > > What Ian was getting at was specifying type=none is the same as not > specifying at all. So on *xl* level we can just expose "host" as the Yes, but this is just a default value so user can set explicitly or don't specify anything in guest .cfg file, I think both cases should be allowed, shouldn't they? Thanks Tiejun > only valid type. > > Ian, correct me if I misunderstand. > > Wei. >