From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aaron Campbell <aaron-rd7evPjynkNeoWH0uzbU5w@public.gmane.org>
Subject: Re: [PATCH 1/3] stringfns: remove rte_snprintf
Date: Thu, 26 Jun 2014 13:20:31 -0300
Message-ID: <5590E373-EC37-4544-A983-52156CFA81E2@arbor.net>
References: <20140624090253.140206a7@nehalam.linuxnetplumber.net>
 <59AF69C657FD0841A61C55336867B5B02CEE3359@IRSMSX103.ger.corp.intel.com>
 <12214985.ClK2CaJOyY@xps13>
 <59AF69C657FD0841A61C55336867B5B02CEF87D2@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\))
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: "Richardson, Bruce" <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <59AF69C657FD0841A61C55336867B5B02CEF87D2-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Jun 26, 2014, at 12:09 PM, Richardson, Bruce =
<bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:

>> I agree we should try to use the "deprecated" attribute when =
possible.
>> So application porting effort will be smoother.
>>=20
>> But in this case, there is something different: as Stephen wrote, =
rte_snprintf
>> is useless. It's useless inside the DPDK so it's even more useless =
for user
>> applications.
>> As it's really useless, it has no sense to keep it as deprecated.
>> Please, let's simply remove it.
>>=20
>=20
> The reason to keep it as deprecated is so that those customers who =
don't want to do a huge amount of search-replace immediately can get =
things working again temporarily using -Wno-deprecated. It provides a =
simple temporary fallback cushion, and then we can completely remove the =
function later.=20
> So, I'd like to see us remove all our usage of the function internally =
in 1.7, along with marking as deprecated, and then completely remove in =
1.8, (i.e. in a week's time or so) :-)

As a DPDK user, I=92d vote to kill it now.  I doubt it is widely used in =
any external applications.  Such usage would be mostly from copy/pasting =
the sample code, is my guess.

-Aaron=