From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [v4][PATCH 12/19] tools/libxl: passes rdm
 reservation policy
Date: Thu, 02 Jul 2015 17:27:20 +0800
Message-ID: <559503F8.1080002@intel.com>
References: <1435053450-25131-1-git-send-email-tiejun.chen@intel.com>	<1435053450-25131-13-git-send-email-tiejun.chen@intel.com>
	<CAFLBxZYf0qwHvRjWWwVsODJtR-HxHA+m5ZmS7=VEwOmLANRrng@mail.gmail.com>
	<55934298.7000605@intel.com> <5593C171.40809@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5593C171.40809@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

> I'm not only suggesting changing the layout of the patches; I'm

Sorry for this misunderstanding.

> suggesting modifying the functionality.
>
> In patch 12 you add a new command-line parameter to xl; so that you have
> to type something like this:
>
> # xl pci-attach ubuntu01 01:00.1,msitranslate=1 relaxed
>
> What I'm saying is that you can drop the xl part of that patch entirely,
> because once you have the xlu code in, you can just do this:
>
> # xl pci-attach ubuntu01 01:00.1,msitranslate=1,rdm_reserve=relaxed
>
> This has the positive advantage that you can copy and paste the same
> string into both the xl command and the xl config file.
>

I think you're right,

pciattach()
     |
     + xlu_pci_parse_bdf()

So I really should drop this patch as you said.

Thanks
Tiejun