From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: Re: [PATCH v7 09/12] eal: Consolidate
 pci_map/unmap_resource() of linuxapp and bsdapp
Date: Fri, 03 Jul 2015 17:52:31 +0900
Message-ID: <55964D4F.6030306@igel.co.jp>
References: <1435306705-11645-4-git-send-email-mukawa@igel.co.jp>
 <1435652668-3380-1-git-send-email-mukawa@igel.co.jp>
 <1435652668-3380-10-git-send-email-mukawa@igel.co.jp>
 <20150702111109.GD3828@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pd0-f177.google.com (mail-pd0-f177.google.com
 [209.85.192.177]) by dpdk.org (Postfix) with ESMTP id 5C0C15A59
 for <dev@dpdk.org>; Fri,  3 Jul 2015 10:52:33 +0200 (CEST)
Received: by pdcu2 with SMTP id u2so61429046pdc.3
 for <dev@dpdk.org>; Fri, 03 Jul 2015 01:52:32 -0700 (PDT)
In-Reply-To: <20150702111109.GD3828@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2015/07/02 20:11, Bruce Richardson wrote:
> On Tue, Jun 30, 2015 at 05:24:25PM +0900, Tetsuya Mukawa wrote:
>> From: "Tetsuya.Mukawa" <mukawa@igel.co.jp>
>>
>> The patch consolidates below functions, and implemented in common
>> eal code.
>>  - pci_map_resource()
>>  - pci_unmap_resource()
>>
>> Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
>> ---
>>  lib/librte_eal/bsdapp/eal/eal_pci.c        | 22 ----------------
>>  lib/librte_eal/common/eal_common_pci.c     | 39 ++++++++++++++++++++++++++++
>>  lib/librte_eal/common/include/rte_pci.h    | 11 ++++++++
>>  lib/librte_eal/linuxapp/eal/eal_pci.c      | 41 ------------------------------
>>  lib/librte_eal/linuxapp/eal/eal_pci_init.h |  5 ----
>>  5 files changed, 50 insertions(+), 68 deletions(-)
>>
> <snip>
>> diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h
>> index 0a2ef09..56dcb46 100644
>> --- a/lib/librte_eal/common/include/rte_pci.h
>> +++ b/lib/librte_eal/common/include/rte_pci.h
>> @@ -364,6 +364,17 @@ int rte_eal_pci_scan(void);
>>   */
>>  int rte_eal_pci_probe(void);
>>  
>> +/**
>> + * Map pci resouce.
>> + */
>> +void *pci_map_resource(void *requested_addr, int fd, off_t offset,
>> +		size_t size, int additional_flags);
>> +
>> +/**
>> + * Map pci resouce.
>> + */
>> +void pci_unmap_resource(void *requested_addr, size_t size);
>> +
> These functions should probably be marked "@internal", right?

Yes, it should be. I will fix it.

Tetsuya