From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [v4][PATCH 04/19] xen/passthrough: extend hypercall to support rdm reservation policy Date: Mon, 06 Jul 2015 22:55:02 +0800 Message-ID: <559A96C6.5050707@intel.com> References: <1435053450-25131-1-git-send-email-tiejun.chen@intel.com> <1435053450-25131-5-git-send-email-tiejun.chen@intel.com> <55927C78.10301@intel.com> <5592A598.60001@eu.citrix.com> <55933E4D.4030405@intel.com> <5593BAAB.20801@eu.citrix.com> <5593C544.2030009@intel.com> <5593FB94.50803@eu.citrix.com> <5594DF1D.3080803@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5594DF1D.3080803@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: Kevin Tian , Keir Fraser , Jan Beulich , Andrew Cooper , Julien Grall , Tim Deegan , "xen-devel@lists.xen.org" , Aravind Gopalakrishnan , Suravee Suthikulpanit , Yang Zhang , Stefano Stabellini , Ian Campbell List-Id: xen-devel@lists.xenproject.org >> * for dt devices: >> - Ignore this flag entirely > > But we still a flag to assign_device() like this, > > diff --git a/xen/drivers/passthrough/device_tree.c > b/xen/drivers/passthrough/device_tree.c > index 5d3842a..a182487 100644 > --- a/xen/drivers/passthrough/device_tree.c > +++ b/xen/drivers/passthrough/device_tree.c > @@ -52,7 +52,8 @@ int iommu_assign_dt_device(struct domain *d, struct > dt_device_node *dev) > goto fail; > } > > - rc = hd->platform_ops->assign_device(d, 0, dt_to_dev(dev)); > + rc = hd->platform_ops->assign_device(d, 0, dt_to_dev(dev), > + XEN_DOMCTL_DEV_RDM_RELAXED); > > if ( rc ) > goto fail; > > Or rc = hd->platform_ops->assign_device(d, 0, dt_to_dev(dev), 0)? > Any comments to this? Thanks Tiejun