From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756913AbbGGLV4 (ORCPT ); Tue, 7 Jul 2015 07:21:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46472 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753991AbbGGLVp (ORCPT ); Tue, 7 Jul 2015 07:21:45 -0400 Subject: Re: [RFC v2 3/6] irq: bypass: Extend skeleton for ARM forwarding control To: "Wu, Feng" , Eric Auger , "eric.auger@st.com" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , "christoffer.dall@linaro.org" , "marc.zyngier@arm.com" , "alex.williamson@redhat.com" , "avi.kivity@gmail.com" , "mtosatti@redhat.com" , "joro@8bytes.org" , "b.reynal@virtualopensystems.com" References: <1436184692-20927-1-git-send-email-eric.auger@linaro.org> <1436184692-20927-4-git-send-email-eric.auger@linaro.org> <559BB167.1030603@redhat.com> <559BB463.6090406@redhat.com> Cc: "linux-kernel@vger.kernel.org" , "patches@linaro.org" From: Paolo Bonzini Message-ID: <559BB642.5010701@redhat.com> Date: Tue, 7 Jul 2015 13:21:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/07/2015 13:18, Wu, Feng wrote: > Then I still need assign prod and de-assign prod in > irq_bypass_register_consumer/irq_bypass_unregister_consumer, Right? > Would you please share why this is better. The need to store the consumer->producer link seems to be unique to posted interrupts. It is difficult to say without seeing the PI code, but I prefer to keep the bypass manager as small as possible. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [RFC v2 3/6] irq: bypass: Extend skeleton for ARM forwarding control Date: Tue, 7 Jul 2015 13:21:38 +0200 Message-ID: <559BB642.5010701@redhat.com> References: <1436184692-20927-1-git-send-email-eric.auger@linaro.org> <1436184692-20927-4-git-send-email-eric.auger@linaro.org> <559BB167.1030603@redhat.com> <559BB463.6090406@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "linux-kernel@vger.kernel.org" , "patches@linaro.org" To: "Wu, Feng" , Eric Auger , "eric.auger@st.com" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , "christoffer.dall@linaro.org" , "marc.zyngier@arm.com" , "alex.williamson@redhat.com" , "avi.kivity@gmail.com" , "mtosatti@redhat.com" , "joro@8bytes.org" , "b.reynal@virtualopensystems.com" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46472 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753991AbbGGLVp (ORCPT ); Tue, 7 Jul 2015 07:21:45 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 07/07/2015 13:18, Wu, Feng wrote: > Then I still need assign prod and de-assign prod in > irq_bypass_register_consumer/irq_bypass_unregister_consumer, Right? > Would you please share why this is better. The need to store the consumer->producer link seems to be unique to posted interrupts. It is difficult to say without seeing the PI code, but I prefer to keep the bypass manager as small as possible. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 From: pbonzini@redhat.com (Paolo Bonzini) Date: Tue, 7 Jul 2015 13:21:38 +0200 Subject: [RFC v2 3/6] irq: bypass: Extend skeleton for ARM forwarding control In-Reply-To: References: <1436184692-20927-1-git-send-email-eric.auger@linaro.org> <1436184692-20927-4-git-send-email-eric.auger@linaro.org> <559BB167.1030603@redhat.com> <559BB463.6090406@redhat.com> Message-ID: <559BB642.5010701@redhat.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/07/2015 13:18, Wu, Feng wrote: > Then I still need assign prod and de-assign prod in > irq_bypass_register_consumer/irq_bypass_unregister_consumer, Right? > Would you please share why this is better. The need to store the consumer->producer link seems to be unique to posted interrupts. It is difficult to say without seeing the PI code, but I prefer to keep the bypass manager as small as possible. Paolo