From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH] x86/MSI: fix guest unmasking when handling
 IRQ via event channel
Date: Wed, 08 Jul 2015 13:33:19 +0100
Message-ID: <559D34AF020000780008E2FB@mail.emea.novell.com>
References: <559D01DE020000780008E03C@mail.emea.novell.com>
	<559CEFD5.6020906@citrix.com>
	<559D1E58020000780008E1E6@mail.emea.novell.com>
	<559D0601.3090009@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <JBeulich@suse.com>) id 1ZCoXR-0006RR-Jk
	for xen-devel@lists.xenproject.org; Wed, 08 Jul 2015 12:33:21 +0000
In-Reply-To: <559D0601.3090009@citrix.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>, Keir Fraser <keir@xen.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, TimDeegan <tim@xen.org>, Julien Grall <julien.grall@citrix.com>, SanderEikelenboom <linux@eikelenboom.it>, xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

>>> On 08.07.15 at 13:14, <david.vrabel@citrix.com> wrote:
> On 08/07/15 11:58, Jan Beulich wrote:
>>>>> On 08.07.15 at 11:39, <david.vrabel@citrix.com> wrote:
>>> On 08/07/15 09:56, Jan Beulich wrote:
>>>> +
>>>>  /* Set IRQ type for an SPI */
>>>>  int irq_set_spi_type(unsigned int spi, unsigned int type);
>>>>  
>>>> --- a/xen/include/xen/irq.h
>>>> +++ b/xen/include/xen/irq.h
>>>> @@ -172,4 +172,8 @@ unsigned int set_desc_affinity(struct ir
>>>>  unsigned int arch_hwdom_irqs(domid_t);
>>>>  #endif
>>>>  
>>>> +#ifndef arch_evtchn_bind_pirq
>>>> +void arch_evtchn_bind_pirq(struct domain *, int pirq);
>>>
>>> ... moving this into xen/include/asm-x86/irq.h
>> 
>> Oh, right, (also to Julien) - this is exactly the reason I do not want it
>> to be an inline function for ARM: I want the declaration here, not
>> replicated in every interested arch's header.
> 
> Ok.
> 
> FWIW, with this requirement I would (instead of the macros) add a weak
> arch_evtchn_bind_pirq() that's a no-op.

Yeah, that's how Linux likes to do it. But we learned the hard way
that weak conflicts with our making symbols hidden by default, so
no, weak is not an option either I'm afraid.

Jan