From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932193AbbGIU7e (ORCPT ); Thu, 9 Jul 2015 16:59:34 -0400 Received: from mail-am1on0090.outbound.protection.outlook.com ([157.56.112.90]:5702 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753894AbbGIU7Z (ORCPT ); Thu, 9 Jul 2015 16:59:25 -0400 Authentication-Results: linux-foundation.org; dkim=none (message not signed) header.d=none; Message-ID: <559EE09B.7090706@ezchip.com> Date: Thu, 9 Jul 2015 16:59:07 -0400 From: Chris Metcalf User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Frederic Weisbecker , LKML CC: Peter Zijlstra , Thomas Gleixner , Don Zickus , Ulrich Obergfell , Andrew Morton Subject: Re: [PATCH 0/4] smpboot/watchdog: Fixes and cleanups References: <1436454992-21462-1-git-send-email-fweisbec@gmail.com> In-Reply-To: <1436454992-21462-1-git-send-email-fweisbec@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: CY1PR21CA0117.namprd21.prod.outlook.com (25.164.213.43) To AM2PR02MB0772.eurprd02.prod.outlook.com (25.163.146.16) X-Microsoft-Exchange-Diagnostics: 1;AM2PR02MB0772;2:5K1Mzew1TLNp6Kh2sREZRtNDbdvW++1SNDpsQq5arqb+UCR+P4GYuoVjiIzFWWbK;3:+Ubb+3rJJxXbOVvwzK2OW/O4x6O2+Nt2Zkst+FurxkZsGtFkWd6vWyb80Ya37qSHTcWBS372jcO0CuSzbF1LgDFpdhwUsoZPaf+NddUBgbxhukUJpGPnHVs0LBcqmwoz5htAudwFL1Gc3VsHhlr4Ig==;25:8IAchmRrd66zZd/WihHcmCONlqik9J6Ehnsi8MBi1LlZhzG9Ud8lkxnGH3tAZ2mKiVb2Yl0HLxQR3hQFbnMenlxjEJHRF/CH1w2KmqRvwGZzrGgqBMVce99OhvegV73nM9YzPs0DRoryLHL/WtoScZh4jHZrG5XpcDauqgChRef+b0It5nR+R/txMeIrIu/vgjQGunt7Po5RLkkDqO4EEjkqUYvXIpmPaOV86HwrraJAv4hMqdrFO3KsdyyrgNLZD9jrJy9UyJYu9UqVyI6Mow==;20:jY1IWYb3yj+4kU0Dm+0fCPvEKcSkcDjsSCNnznNN6P0OfdB/hy343azIa5niCqgpiAiHJIxRRH9VEPdMaLBUr/k7WQVPUi6puSgWsNjGcUp8uigJFNOCQZaQNiu+kDI1Z1GWX7TjJYI2hTFhj528TKkFlboNk4DDhCbZHaXiBdM= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM2PR02MB0772; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:AM2PR02MB0772;BCL:0;PCL:0;RULEID:;SRVR:AM2PR02MB0772; X-Microsoft-Exchange-Diagnostics: 1;AM2PR02MB0772;4:Eyhyfy1fdvTQbm00X23ilkaC+8o6hjcu80mm4nrWBfr1GqVNhgyWvd/XFYiq2FSKMrAVGh1SlXaVGIrOY3bZB748GxQa+yfC3Im+uAinmdmIMyddV3CwPMhb11/jdz0HYLzKUA2noRJ46jFLN20QzNf6OK9JszCT8REbqFL9j95NrqpYqmJr9qCRTU+i77DV1ZR3yw2gww1CIgW7rvLiGvGsobBadsxumdbsdyaK9PWOo4xFLQZ0wQ9pB8Klr7MwiMGCziZasrHXu2Tq5+kAMqcUHiB6gK8dOtbJJjtvlHQ= X-Forefront-PRVS: 0632519F33 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(377454003)(479174004)(51704005)(164054003)(65956001)(47776003)(122386002)(65816999)(77096005)(86362001)(2950100001)(46102003)(189998001)(64126003)(19580395003)(80316001)(15975445007)(19580405001)(62966003)(87266999)(50986999)(54356999)(76176999)(33656002)(65806001)(77156002)(40100003)(50466002)(5001960100002)(87976001)(42186005)(36756003)(23746002)(92566002)(66066001)(5001770100001)(4001350100001)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM2PR02MB0772;H:[10.7.0.41];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM2PR02MB0772;23:suRJNDl3rZTGAR4hHJIwdzjJZ604IpYbLqTbr?= =?Windows-1252?Q?VYqOgSUgX+Pa6P0O1VGeaeO5aoBQPxBlBx01K0t1rkI25ChW63JPPUJ5?= =?Windows-1252?Q?FZH5S+Kr0/lAS9z9HcxfgN3KEkCW0E/1O65oLREy0Cslzc3X8joSuBFF?= =?Windows-1252?Q?hTtLh+Ih83Q1Ympxp7ng/QZQrLe5mFEg4mgJTkaXXm5M7hooXiYsLUOU?= =?Windows-1252?Q?5zVvC6+6IBFAWQdA6pqZCUi8MbVx65Mt4x9SRUwmzdD0Y2FcsvGAqT/r?= =?Windows-1252?Q?s+8gg8y0Ner0uH0hpLG9eclYvJ1kaPTDjOOKMTgSrQ7pAHNKj7qh5IiP?= =?Windows-1252?Q?tyk4BXTrODzSpFkGhPbiYRAaNmW49S0Fj/ny6sTT2siU0y6FspgjfADI?= =?Windows-1252?Q?mKiYk/utfwzN2xrmXsR85Vcp7cBa1JdZmKvzh/vYTJ3JhCzEofoKDxDb?= =?Windows-1252?Q?LUVBRb2nNao3sqbazrqI4XFQemR5oPNUI6g9D7H+zK9Nn3x3I+wbBZKA?= =?Windows-1252?Q?Lv0ZeIZgXgcwXhUiOs+Sx3g6RkE0/rz4ITQwftMgpSvWnlulDfdN8yJ0?= =?Windows-1252?Q?8zt2zw5VT6fPdozNHWXbzHPRbWIuIWNdJk2w9+TkBao6+jjkR1Ycl6y+?= =?Windows-1252?Q?DMcMu+M6TzlV+fOfQWX1BmhtZz7vWl30ywSEA90kf4H6oU/jeahPocMG?= =?Windows-1252?Q?YrvugSJlXRBKdH+UVd3FONdbsqwGUruPkyPCsE9AD29pd4NFmohXBuqq?= =?Windows-1252?Q?fU978HSnooANJAjihUG8bl3uYJu18nuUQJd3j+f901pw+tocf/NCyLFZ?= =?Windows-1252?Q?HEdsbONBQeBAjLcGtBXzXUPgqaa241l6w4IIADro08q9oOlPcLPYX0gd?= =?Windows-1252?Q?DIo3UfxVx5o3cGWibpc5xVDnBC7a1dOSQ4DAW75n+WllTKhazliO4f8x?= =?Windows-1252?Q?yp6/gRg1cFnsZySIwBQLkgZrBOcQP9Ao7PhaBrdOcPkRh49wO/wDNtJw?= =?Windows-1252?Q?scnQfT+NNtWc0rkmuxZaIGkivckXvwQY8ihyQrJQOhZLmcDSTOmVi85H?= =?Windows-1252?Q?pIqkw/5jUTgxdSj732HuojNDT/62PiFsuXO51ECUpJZabw+yiordBLEQ?= =?Windows-1252?Q?eD/JWrnzPFBu0cqlRun48qT+wa5DSYXOLSiGNIxbkP+?= X-Microsoft-Exchange-Diagnostics: 1;AM2PR02MB0772;5:dHkXiDai7f1EhJVCJGoF0wvcYVPyuyNEjkYq4w53bzTbQ6JMZgSEwV4W2LyRaI0AQhXWPLlkRoI1qrqLA2kI+e0arfRj5eoh+QiAlKj+Fx0QDltI2edJE04QyifCWoym3wqVFj0CiFOO1DvzlBB8WQ==;24:Z6GZSAcr5LMj/h7Vly3ZjYm76B/yc1qNVzHflj1CKawk5noez3D6IDS8FYxrNw/HRvecrYBxfD+eVuXp84X/UxNvBSGXyUBFmw1uVnM7K/Q=;20:ziSz3JXF1lb5chQuy8OZXDWaAYxRHactmgaUB5c9f6JN917G0mncOKpgXNG/4W/PdXXU7cE+HK5cap3FP/2LRQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2015 20:59:20.5750 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR02MB0772 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/09/2015 11:16 AM, Frederic Weisbecker wrote: > Hi, > > The 2nd patch should fix the strange bug we've seen with Chris. > > git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git > core/watchdog > > HEAD: 5e36d90b3ccb0023ad54ac7a2381c132c6b12280 > > Thanks, > Frederic > --- > > Frederic Weisbecker (4): > smpboot: Fix memory leak on error handling > smpboot: Make cleanup to mirror setup > smpboot: Allow to pass the cpumask on per-cpu thread registration > watchdog: Simplify housekeeping affinity with the appropriate mask > > > include/linux/smpboot.h | 11 ++++++++++- > kernel/smpboot.c | 22 +++++++++------------- > kernel/watchdog.c | 15 +++++---------- > 3 files changed, 24 insertions(+), 24 deletions(-) You can add my Reviewed-by: Chris Metcalf to all four. There are a couple of typos in the commit message for patch 2/4: "ressources" and "lets simply" (should be "let's simply"). Glad you figured out what the bug was. Curious that in your environment you got a panic rather than an infinite loop waiting for a timer subsystem pointer to go non-NULL. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com