From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2 07/27] tools/libxl: Extra management APIs for the save helper Date: Fri, 10 Jul 2015 10:52:36 +0100 Message-ID: <559F95E4.7040103@citrix.com> References: <1436466413-25867-1-git-send-email-andrew.cooper3@citrix.com> <1436466413-25867-8-git-send-email-andrew.cooper3@citrix.com> <1436521305.23508.198.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1436521305.23508.198.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Wei Liu , Ian Jackson , Xen-devel List-Id: xen-devel@lists.xenproject.org On 10/07/15 10:41, Ian Campbell wrote: > On Thu, 2015-07-09 at 19:26 +0100, Andrew Cooper wrote: >> With migration v2, there are several moving parts needing to be juggled at >> once. This requires the error handling logic to be able to query the state of >> each moving part, possibly before they have been started, and be able to >> cancel them. > Arguably helper_{stop,failed,done} all ought to be patched to use the > new libxl__save_helper_inuse helper. So they should. Done. ~Andrew > This isn't a blocker IMHO so, > nonetheless: > >> Signed-off-by: Andrew Cooper > Acked-by: Ian Campbell > >