From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFI84-0001ta-4y for qemu-devel@nongnu.org; Wed, 15 Jul 2015 04:33:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFI83-0005SJ-DM for qemu-devel@nongnu.org; Wed, 15 Jul 2015 04:33:24 -0400 References: <1436938201-16766-1-git-send-email-jasowang@redhat.com> <1436938201-16766-3-git-send-email-jasowang@redhat.com> <55A61261.7010401@redhat.com> <55A61A70.4090109@redhat.com> From: Paolo Bonzini Message-ID: <55A61AC6.2050805@redhat.com> Date: Wed, 15 Jul 2015 10:33:10 +0200 MIME-Version: 1.0 In-Reply-To: <55A61A70.4090109@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2 2/5] virtio-blk: advertise scsi only when scsi is set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang , qemu-devel@nongnu.org Cc: kwolf@redhat.com, cornelia.huck@de.ibm.com, qemu-block@nongnu.org, stefanha@redhat.com, mst@redhat.com On 15/07/2015 10:31, Jason Wang wrote: > > This must only be done for newer machine types only, or you change guest > > ABI for scsi=off. Effectively you have to split it in two properties, > > "scsi" and "always_set_f_scsi". > > And always_set_f_scsi is true only for legacy machine types? s/legacy/older/ :) It's also ignored for modern devices. So perhaps you could name it to transitional_force_f_scsi or something like that. Paolo