All of lore.kernel.org
 help / color / mirror / Atom feed
From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCH 3/3] block: Refuse adding appending a gapped integrity page to a bio
Date: Thu, 16 Jul 2015 09:58:46 -0600	[thread overview]
Message-ID: <55A7D4B6.9020101@kernel.dk> (raw)
In-Reply-To: <20150716092646.GA17712@infradead.org>

On 07/16/2015 03:26 AM, Christoph Hellwig wrote:
> On Wed, Jul 15, 2015@09:28:23AM -0600, Jens Axboe wrote:
>> This chunk of code largely ends up being duplicated in several places with
>> your patches, might be a good idea to pull that into a helper function. Then
>> you can add the comment in one place as well :-)
>
> Basically all the bio_vec-related code in block-integrity is copy &
> paste of the I/O path.  In the long run we'll need to refactor it by
> adding bio_vec iteration helpers that can pick different anchors from
> the bio.  But for now I think I'd rather have this quick fix.

I wasn't asking for a refactor of the bio_vec integrity code (though 
that would be nice...), just that we don't add 3 more instances of 'does 
this gap with previous'.

-- 
Jens Axboe

  reply	other threads:[~2015-07-16 15:58 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15 13:19 [PATCH 0/3] Fixes for gapped scatters Sagi Grimberg
2015-07-15 13:19 ` [PATCH 1/3] block: copy multi iovec user mappings if QUEUE_FLAG_SG_GAPS is set Sagi Grimberg
2015-07-16 16:47   ` Keith Busch
2015-07-16 16:49     ` Jens Axboe
2015-07-16 19:47       ` Matthew Wilcox
2015-07-17 15:26         ` Jens Axboe
2015-07-17  7:44       ` Christoph Hellwig
2015-07-17  7:43     ` Christoph Hellwig
2015-07-15 13:19 ` [PATCH 2/3] block: Refuse request/bio merges with gaps in the integrity payload Sagi Grimberg
2015-07-15 13:19 ` [PATCH 3/3] block: Refuse adding appending a gapped integrity page to a bio Sagi Grimberg
2015-07-15 15:28   ` Jens Axboe
2015-07-16  9:26     ` Christoph Hellwig
2015-07-16 15:58       ` Jens Axboe [this message]
2015-07-19 15:18         ` Sagi Grimberg
2015-08-19  9:40           ` Christoph Hellwig
2015-08-19 10:30             ` Sagi Grimberg
2015-08-19 10:42               ` Christoph Hellwig
2015-09-02  8:04                 ` Sagi Grimberg
2015-09-02 14:37                   ` Jens Axboe
2015-09-02 17:30                     ` Sagi Grimberg
2015-09-02 18:03                       ` Jens Axboe
2015-09-02 19:18                       ` Jens Axboe
2015-09-03  9:07                         ` Sagi Grimberg
2015-09-03 14:53                           ` Jens Axboe
2015-09-03 15:04                           ` Jens Axboe
2015-09-03 15:41                             ` Sagi Grimberg
2015-09-03 15:52                               ` Jens Axboe
2015-07-17  1:50       ` Martin K. Petersen
2015-07-17  1:39 ` [PATCH 0/3] Fixes for gapped scatters Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A7D4B6.9020101@kernel.dk \
    --to=axboe@kernel.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.